Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brew.sh: remove HOMEBREW_DEVELOPER condition #9251

Merged
merged 1 commit into from
Nov 21, 2020
Merged

brew.sh: remove HOMEBREW_DEVELOPER condition #9251

merged 1 commit into from
Nov 21, 2020

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Nov 21, 2020 •
edited
Loading

This env variable is filtered out on test-bot.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

@iMichka
brew.sh: remove HOMEBREW_DEVELOPER condition
4e1e280 
This env variable is filtered out on test-bot.
@iMichka iMichka requested a review from dawidd6 November 21, 2020 23:07
@iMichka iMichka self-assigned this Nov 21, 2020
@BrewTestBot
Copy link
Member

Review period will end on 2020-11-24 at 23:07:34 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 21, 2020
@dawidd6 dawidd6 removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 21, 2020
@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 21, 2020
@dawidd6 dawidd6 merged commit 5d0c686 into Homebrew:master Nov 21, 2020
@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Nov 21, 2020
@iMichka iMichka deleted the fix2 branch November 22, 2020 08:57
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 23, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 23, 2020
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 23, 2020
@BrewTestBot
Copy link
Member

Review period ended.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@dawidd6 dawidd6 dawidd6 approved these changes

Assignees

@iMichka iMichka

Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iMichka @BrewTestBot @dawidd6