-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pr-pull: prepare replacement for --workflow flag #9424
Conversation
Review period will end on 2020-12-07 at 21:25:01 UTC. |
if replacement.nil? | ||
process_option(*names, description) | ||
else | ||
description += " (disabled#{"; replaced by #{replacement}" if replacement.present?})" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you intentionally handling a case where this is not nil?
but also not present?
If not, it'd be nice to just check .blank?
above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention here is that a flag can set replacement: false
which will just append "(disabled)" in the help output and show "{flag} is disabled! There is no replacement." when called.
Review period ended. |
8aede8d
to
9dec442
Compare
thanks again @EricFromCanada! |
brew style
with your changes locally?brew tests
with your changes locally?brew man
locally and committed any changes?Add support for flag replacement, as was done for switches in #9316. Assuming that the disabling of the old flag should wait for the next minor release.