Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caveats: remove ZSH FPATH logic. #9480

Merged
merged 1 commit into from
Dec 9, 2020
Merged

caveats: remove ZSH FPATH logic. #9480

merged 1 commit into from
Dec 9, 2020

Conversation

MikeMcQuaid
Copy link
Member

This is too error-prone and full of edge cases.

Fixes #9455

@MikeMcQuaid
caveats: remove ZSH FPATH logic.
1f8fd2a 
This is too error-prone and full of edge cases.

Fixes #9455
@BrewTestBot
Copy link
Member

Review period will end on 2020-12-10 at 11:50:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 9, 2020
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Dec 9, 2020
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 9, 2020
@BrewTestBot
Copy link
Member

BrewTestBot commented Dec 9, 2020 •
edited
Loading

Review period ended.

@MikeMcQuaid MikeMcQuaid merged commit 7b2eb23 into Homebrew:master Dec 9, 2020
@MikeMcQuaid MikeMcQuaid deleted the caveats-zsh-remove branch December 9, 2020 12:46
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 9, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zsh completion path check broke upgrade
2 participants
@MikeMcQuaid @BrewTestBot