Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add headers to content in curl_http_content_headers_and_checksum. #9500

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Dec 10, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Headers are already output to stdout, so don't also include them in the file output.

@reitermarkus reitermarkus changed the title Don't add headers to content in `curl_http_content_headers_and_checks… Don't add headers to content in curl_http_content_headers_and_checksum. Dec 10, 2020
@BrewTestBot
Copy link
Member

Review period will end on 2020-12-11 at 11:37:20 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 10, 2020
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 11, 2020
@BrewTestBot
Copy link
Member

Review period ended.

@reitermarkus reitermarkus merged commit ee858ae into Homebrew:master Dec 11, 2020
@reitermarkus reitermarkus deleted the fix-curl_http_content_headers_and_checksum branch December 11, 2020 13:52
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 11, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants