Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable HOMEBREW_PATCHELF_RB_WRITE by default #9522

Merged
merged 1 commit into from Dec 15, 2020
Merged

Enable HOMEBREW_PATCHELF_RB_WRITE by default #9522

merged 1 commit into from Dec 15, 2020

Conversation

sjackman
Copy link
Member

@sjackman sjackman commented Dec 12, 2020 •
edited

It may be disabled using HOMEBREW_NO_PATCHELF_RB_WRITE.

It is currently disabled in brew test-bot when building bottles.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

@sjackman
Enable HOMEBREW_PATCHELF_RB_WRITE by default
8171610 
It may be disabled using HOMEBREW_NO_PATCHELF_RB_WRITE.

It is currently disabled in brew test-bot when building bottles.
@sjackman sjackman self-assigned this Dec 12, 2020
@BrewTestBot
Copy link
Member

Review period will end on 2020-12-15 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 12, 2020
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 15, 2020
@BrewTestBot
Copy link
Member

Review period ended.

@iMichka iMichka merged commit 3d56d1b into Homebrew:master Dec 15, 2020
@sjackman sjackman deleted the sj/patchelf-rb-write branch December 15, 2020 20:17
@sjackman
Copy link
Member Author

@rmNULL patchelf.rb has been enabled by default for all users. Thank you for your work, and congratulations!

jarrodldavis added a commit to jarrodldavis/dotfiles that referenced this pull request Jan 8, 2021
@jarrodldavis
zsh: update homebrew initialization
b05dcdc 
- zsh: ensure shell replacement occurs as early as possible and only if
  Homebrew is installed
- zsh: reindent
- zsh: remove HOMEBREW_PATCHELF_RB_WRITE since it is now enabled by
  default (Homebrew/brew#9522)
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 15, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@iMichka iMichka iMichka approved these changes

@woodruffw woodruffw Awaiting requested review from woodruffw

@dawidd6 dawidd6 Awaiting requested review from dawidd6

Assignees

@sjackman sjackman

Labels
enhancement linux outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sjackman @BrewTestBot @MikeMcQuaid @iMichka