Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Add font-ibm-plex v0.4.1 #1365

Merged
merged 2 commits into from
Nov 13, 2017
Merged

Add font-ibm-plex v0.4.1 #1365

merged 2 commits into from
Nov 13, 2017

Conversation

alanorth
Copy link
Contributor

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.

@commitay
Copy link
Contributor

From: IBM/plex#70 (comment)

One requirement for inclusion in that particular package manager's repository is that package releases must be tagged

See the formula cookbook where it states this requirement: https://github.com/Homebrew/brew/blob/master/docs/Formula-Cookbook.md

This requirement is for homebrew/core not Cask, we prefer versioned releases but it isn't a deal breaker.

https://github.com/caskroom/homebrew-fonts/blob/cb406b6bd3096ad5c16e4e1c1edcc3badf75a4a5/Casks/font-space-mono.rb#L1-L13

@alanorth
Copy link
Contributor Author

alanorth commented Nov 12, 2017

Thanks, @commitay! I only realized that Caskroom itself didn't require versioned releases after I posted that tip to the IBM type team. Well happy that it all worked out, as it looks like IBM will start tagging their releases. :)

@nickv2002
Copy link

nickv2002 commented Nov 13, 2017

Is the plan now to wait for a versioned Plex release before merging?

@alanorth
Copy link
Contributor Author

@nickv2002 I'm not sure what @commitay is waiting for actually. Upstream already tagged the current release and this formula uses it. 🙌

@commitay commitay merged commit d4a1d1c into Homebrew:master Nov 13, 2017
@nickv2002
Copy link

Works great now with brew update; brew cask install font-ibm-plex. Thanks all!

@alanorth alanorth deleted the font-ibm-plex branch November 14, 2017 05:36
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants