This repository has been archived by the owner on May 2, 2024. It is now read-only.
Added arm64 specific version / checksum / url for zulu13 #10177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreate PR for #10101 as Homebrew/brew#7857 is resolved, and homebrew is supporting arm64 devices officially.
Following contents come from original PR.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
After making all changes to a cask, verify:
brew audit --cask {{cask_file}}is error-free.brew style --fix {{cask_file}}reports no offenses.Additionally, if adding a new cask:Not adding a new cask, skipped.I wonder if we should make
zulu13install arm64 version on apple silicon devices, or we should create a new cask. The former one seems more intuitive for me, so I created this PR.If this PR is approved and merged, I may create PRs for arm64 versions of
zulu11andzulu8as well. Azul doesn't released arm64 version ofzulu(15) andzulu7right now, so they will remain untouched.