Upgrade PhpStorm EAP to 141.1717

[bchatard]

Hello,

I try to follow guideline from #879. Let me know if some parts are missing or if there are some mistakes.

Hope this help

Replace PR #1074

// cc @sebroeder

[deizel]

👍 - Can we get this merged before bumping the version again? (141.1815 was released earlier today.)

Since this Cask tracks PhpStorm 9.x, this PR helps target the correct WebIde90 directories (vs WebIde80).

$ find ~ -type d -name '*WebIde90'
/Users/deizel/.WebIde90
/Users/deizel/Library/Application Support/WebIde90
/Users/deizel/Library/Caches/WebIde90
/Users/deizel/Library/Logs/WebIde90
/Users/deizel/Library/Preferences/WebIde90

[vitorgalvao]

It has a “no newline at end of file” warning. Those are actually meaningful.

[vitorgalvao]

@deizel I’d like for @sebroeder’s input first, since he has been working hard on this, and I do not wish to undo any of the work.

[sebroeder]

Thanks for your work @bchatard and sorry for my late reply @deizel, @vitorgalvao.

The cask looks good, the name stanza is missing, though and homepage URL could be https as well. Maybe you can change this while you add the missing newline at the end of the file, @bchatard? You can just add another commit to your existing branch and push it to GitHub, no need for a new Pull Request. If you want to, you could also bump the version to the newer 141.1815 (the Jetbrains folks are killing me with there insane release frequency).

Let me know if you need any more help (I am a little busy at the moment but I’ll try to answer as quickly as possible). The official Cask Language Reference is a recommended read, too.

[bchatard]

@sebroeder & @vitorgalvao thanks for your feedback. I just push the fixes.
I do not upgrade version to the last one in this PR. I'm agree with @deizel, this is a good step to ensure cask quality before upgrading to the new version.
When this PR will be ok, I (or someone else) will push a PR to upgrade version.

[bchatard]

I don't understand this error, could you help me please?

[vitorgalvao]

It’s just Travis chocking. Don’t worry.

[bchatard]

@vitorgalvao thanks!

[deizel]

When this PR will be ok, I (or someone else) will push a PR to upgrade version.

Looks like there is a PR waiting already :) #1102

/ping @sebroeder

[deizel]

@vitorgalvao Seems the 9.0 EAP is now closed - do the casks get deleted now? (see 4e5408b)

@sebroeder, @vitorgalvao, the stable cask could use some of the improvements from this PR?

Let me know, happy to submit PRs.

[sebroeder]

@deizel The casks for EAPs do not get deleted, even if an EAP is temporarily closed. This makes it very easy for us to just update the cask when a new EAP starts. The PhpStorm EAP is already open again.

Feel free to bring the changes from #879 over to the stable cask. I just didn't do it yet because I want to finish #879 first and personally use only the bundled-jdk versions. Things might get easier in the future, though.

[sebroeder]

Looks like there is a PR waiting already :) #1102

Unfortunately this one is not based on your improvements.

@vitorgalvao could you please merge this PR so that #1102 can be rebase on it?

[jawshooah]

Thank you for the contribution. It needed some fixes, so they were made in 16f32b7. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.

[vitorgalvao]

Missed your request, @sebroeder, apologies. Thank you for the catch, @jawshooah.