Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Upgrade java8 version to 1.8.0_152 #4611

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Upgrade java8 version to 1.8.0_152 #4611

merged 1 commit into from
Oct 18, 2017

Conversation

chrisng
Copy link
Contributor

@chrisng chrisng commented Oct 18, 2017

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if updating only the sha256:

  • I verified this change is legitimate How do I do that? and am providing confirmation below:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.

@commitay commitay merged commit ac0ed09 into Homebrew:master Oct 18, 2017
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrisng @commitay