New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reaper-arm: Add ARM version of REAPER for compatibility with VLC and enable video editing #107338
Conversation
…enable video editing ### Why Is This Necessary If `reaper.rb` Already Exists? Video editing requires compatibility with VLC, [which is installed with ARM](https://github.com/Homebrew/homebrew-cask/blob/77b86126e8fe50329d80c228c39681aaf46fa353/Casks/vlc.rb#L12). But [audio plugins may not work with ARM](https://www.reaper.fm/download.php), so I think it makes sense to continue pointing `reaper.rb` to x64 and have a separate Cask instead.
Ooops, the tests fail because this Cask is unavailable for x64 computers but GitHub Actions don’t support macOS with M1 yet… What should I do? |
Why not make this an alternative download for reaper? |
Hmmm, “alternative downloads,” what are they? Something that the user can select which version to install? If so, that’d be cool, can you please point me at right direction to make it work? On the other hand, if you mean and if-then-else checking the architecture and always installing the ARM version in ARM computers, then I think that’s a bad idea. I think that users should be able to select the version that’ll be compatible with the rest of their setup: VLC as installed via Homebrew is compatible with ARM, and many audio plugins are x64-only. |
This is what I meant. Counter argument though, these people knowingly bought an M1 powered mac so they should expect stuff not to be perfect yet. And they can always run brew in Rosetta mode to install the Intel versions. |
Hmmm, you make good points, but I don’t think it applies in REAPER’s case. The main use case for most people is music production; my main use case (video editing) is merely a side-gig for REAPER. So I think that maintaining compatibility with audio plugins is more important than VLC. That said, if you’re still unconvinced, then I’m happy to change the pull request the way you suggested. Just let me know 😃 |
We can always go for your route if too many people find this inconvenient. I think providing a native install as default should be the first step. |
👍 I changed the pull request to have a single |
There is probably an issue with this update, which our CI can't catch right now as we don't test ARM (#107586). The ARM-variant uses different app names:
Right now, the Cask will try to install:
|
Oops, yeah, thanks for catching my mistake—I forgot to change that part when I merged |
Why Is This Necessary If
reaper.rb
Already Exists?Video editing requires compatibility with VLC, which is installed with ARM. But audio plugins may not work with ARM, so I think it makes sense to continue pointing
reaper.rb
to x64 and have a separate Cask instead.Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making all changes to a cask, verify:
brew audit --cask <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --new-cask <cask>
worked successfully.brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.