Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reaper-arm: Add ARM version of REAPER for compatibility with VLC and enable video editing #107338

Merged
merged 2 commits into from Jun 24, 2021

Conversation

leafac
Copy link
Contributor

@leafac leafac commented Jun 15, 2021

Why Is This Necessary If reaper.rb Already Exists?

Video editing requires compatibility with VLC, which is installed with ARM. But audio plugins may not work with ARM, so I think it makes sense to continue pointing reaper.rb to x64 and have a separate Cask instead.


Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference. I think so, but I couldn’t find a precedent of this situation with two valid versions of the application with different architectures…
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo. Maybe it should go to https://github.com/Homebrew/homebrew-cask-versions? Again, I couldn’t find a precedent…
  • brew audit --new-cask <cask> worked successfully.
  • brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

…enable video editing

### Why Is This Necessary If `reaper.rb` Already Exists?

Video editing requires compatibility with VLC, [which is installed with ARM](https://github.com/Homebrew/homebrew-cask/blob/77b86126e8fe50329d80c228c39681aaf46fa353/Casks/vlc.rb#L12). But [audio plugins may not work with ARM](https://www.reaper.fm/download.php), so I think it makes sense to continue pointing `reaper.rb` to x64 and have a separate Cask instead.
@leafac
Copy link
Contributor Author

leafac commented Jun 15, 2021

Ooops, the tests fail because this Cask is unavailable for x64 computers but GitHub Actions don’t support macOS with M1 yet…

What should I do?

@SMillerDev
Copy link
Member

Why not make this an alternative download for reaper?

@leafac
Copy link
Contributor Author

leafac commented Jun 16, 2021

Hmmm, “alternative downloads,” what are they? Something that the user can select which version to install? If so, that’d be cool, can you please point me at right direction to make it work?

On the other hand, if you mean and if-then-else checking the architecture and always installing the ARM version in ARM computers, then I think that’s a bad idea. I think that users should be able to select the version that’ll be compatible with the rest of their setup: VLC as installed via Homebrew is compatible with ARM, and many audio plugins are x64-only.

@SMillerDev
Copy link
Member

On the other hand, if you mean and if-then-else checking the architecture and always installing the ARM version in ARM computers, then I think that’s a bad idea. I think that users should be able to select the version that’ll be compatible with the rest of their setup: VLC as installed via Homebrew is compatible with ARM, and many audio plugins are x64-only.

This is what I meant. Counter argument though, these people knowingly bought an M1 powered mac so they should expect stuff not to be perfect yet. And they can always run brew in Rosetta mode to install the Intel versions.

@leafac
Copy link
Contributor Author

leafac commented Jun 18, 2021

Hmmm, you make good points, but I don’t think it applies in REAPER’s case. The main use case for most people is music production; my main use case (video editing) is merely a side-gig for REAPER. So I think that maintaining compatibility with audio plugins is more important than VLC.

That said, if you’re still unconvinced, then I’m happy to change the pull request the way you suggested. Just let me know 😃

@SMillerDev
Copy link
Member

We can always go for your route if too many people find this inconvenient. I think providing a native install as default should be the first step.

@leafac
Copy link
Contributor Author

leafac commented Jun 23, 2021

👍 I changed the pull request to have a single reaper Cask which installs the ARM version on Macs with the M1 processor.

@miccal miccal merged commit a9d4730 into Homebrew:master Jun 24, 2021
@cho-m
Copy link
Member

cho-m commented Jun 24, 2021

There is probably an issue with this update, which our CI can't catch right now as we don't test ARM (#107586).

The ARM-variant uses different app names:

  • REAPER-ARM.app
  • ReaMote-ARM.app

Right now, the Cask will try to install:

  • REAPER.app
  • ReaMote.app

@leafac leafac deleted the reaper branch June 24, 2021 07:38
@leafac
Copy link
Contributor Author

leafac commented Jun 24, 2021

Oops, yeah, thanks for catching my mistake—I forgot to change that part when I merged reaper-arm.rb into reaper.rb.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants