Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maciasl.rb #112079

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Update maciasl.rb #112079

merged 2 commits into from
Oct 4, 2021

Conversation

naveenkrdy
Copy link
Contributor

@naveenkrdy naveenkrdy commented Oct 4, 2021

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making all changes to a cask, verify:

@naveenkrdy naveenkrdy mentioned this pull request Oct 4, 2021
@bevanjkay
Copy link
Member

@naveenkrdy The :github_latest livecheck strategy is only required in instances that the standard :git strategy isn't suitable. When the source url is from GitHub we can omit the livecheck stanza as it is inferred.

https://docs.brew.sh/Brew-Livecheck#general-guidelines

@bevanjkay bevanjkay merged commit bb5b34c into Homebrew:master Oct 4, 2021
@naveenkrdy
Copy link
Contributor Author

@naveenkrdy The :github_latest livecheck strategy is only required in instances that the standard :git strategy isn't suitable. When the source url is from GitHub we can omit the livecheck stanza as it is inferred.

docs.brew.sh/Brew-Livecheck#general-guidelines

thanks for the heads up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants