Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EasyConnect.app #141884

Closed
wants to merge 1 commit into from
Closed

Add EasyConnect.app #141884

wants to merge 1 commit into from

Conversation

HuaDeity
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask <cask> worked successfully.
  • brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Need some help for the livecheck stanza.

Comment on lines +10 to +13
livecheck do
url :url
strategy :extract_plist
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not suitable -- you cannot use a versioned url for livecheck. Can you perhaps find an alternate url to use?

@miccal miccal added the awaiting user reply Issue needs response from a user. label Feb 25, 2023
@HuaDeity
Copy link
Contributor Author

HuaDeity commented Feb 25, 2023 via email

@miccal
Copy link
Member

miccal commented Feb 25, 2023

/usr/bin/sudo -E LOGNAME=runner USER=runner USERNAME=runner -- /usr/sbin/installer -pkg /usr/local/Caskroom/easyconnect/7.6.7,4/Install\ EasyConnect.pkg -target /
==> Installing artifact of class Cask::Artifact::Pkg
==> Running installer for easyconnect; your password may be necessary.
Package installers may write to any location; options such as `--appdir` are ignored.
Error: The action has timed out.

From what I can see looking inside the pkg, this would require allow_untrusted: true which we do not allow.

Thank you for your submission @HuaDeity, but we cannot accept this in homebrew-cask.

@miccal miccal closed this Feb 25, 2023
@miccal miccal removed the awaiting user reply Issue needs response from a user. label Feb 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants