Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AMM #162449

Closed
wants to merge 1 commit into from
Closed

Add AMM #162449

wants to merge 1 commit into from

Conversation

nihaals
Copy link
Contributor

@nihaals nihaals commented Dec 13, 2023

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@nihaals
Copy link
Contributor Author

nihaals commented Dec 13, 2023

amm was taken so I used automatic-mouse-mover instead just as a temporary name. prashantgupta24-amm feels weird so I'm not sure what to use.

Also this is a purely menu bar app. Should uninstall include quit? I haven't really noticed a pattern with it as most casks don't include it when it might make sense on every cask.

@nihaals
Copy link
Contributor Author

nihaals commented Dec 13, 2023

Although based on it not having a signature it might not matter

@krehel
Copy link
Member

krehel commented Dec 13, 2023

Yeah, sorry @nihaals. Since the application is unsigned, we can't accept it.

macOS on ARM requires software to be signed. Please contact the upstream developer to let them know they should sign and notarize their software.

Please consider hosting this in your own Tap and if the developers sign their app in the future we would then be happy to consider adding this to homebrew-cask.

@krehel krehel closed this Dec 13, 2023
@nihaals nihaals deleted the add-amm branch December 13, 2023 20:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants