Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update livecheck/homepage to avoid redirections #173158

Merged
merged 11 commits into from
May 8, 2024

Conversation

samford
Copy link
Member

@samford samford commented May 8, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

This updates the livecheck block url and/or homepage for various casks to resolve unnecessary redirections. This doesn't include URLs that redirect from an upstream URL to a third-party host (e.g., AWS, etc.), as those sorts of redirections can be useful.

@samford samford added the livecheck Issues or PRs related to livecheck label May 8, 2024
@samford samford force-pushed the 2024-05-07-url-redirections branch from ddc48e3 to d774cbc Compare May 8, 2024 01:03
@miccal miccal merged commit cdc9e7e into Homebrew:master May 8, 2024
35 checks passed
@samford samford deleted the 2024-05-07-url-redirections branch May 8, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants