Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jalview 2.11.3.3 #174539

Merged
merged 5 commits into from
May 22, 2024
Merged

jalview 2.11.3.3 #174539

merged 5 commits into from
May 22, 2024

Conversation

benzoid
Copy link
Contributor

@benzoid benzoid commented May 22, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Casks/j/jalview.rb Outdated Show resolved Hide resolved
@krehel krehel changed the title Update Jalview to 2.11.3.3 jalview 2.11.3.3 May 22, 2024
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please allow maintainers to push to your fork in the future. It allows us to make quick fixes and then get things merged.

Casks/j/jalview.rb Outdated Show resolved Hide resolved
Co-authored-by: Patrick Linnane <patrick@linnane.io>
@p-linnane p-linnane requested a review from krehel May 22, 2024 17:54
@benzoid
Copy link
Contributor Author

benzoid commented May 22, 2024

Please allow maintainers to push to your fork in the future. It allows us to make quick fixes and then get things merged.

Will do -- how is this done?
(Thanks for help with the livecheck _ -> .)

@p-linnane
Copy link
Member

@miccal miccal merged commit ce3d3e4 into Homebrew:master May 22, 2024
10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants