New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Lepton.app v1.2.0 #30575

Merged

vitorgalvao merged 2 commits into Homebrew:master from YuerLee:lepton-app

Mar 4, 2017

Contributor

YuerLee commented Mar 4, 2017

After making all changes to the cask:

brew cask audit --download {{cask_file}} is error-free.
brew cask style --fix {{cask_file}} reports no offenses.
The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

Named the cask according to the token reference.
brew cask install {{cask_file}} worked successfully.
brew cask uninstall {{cask_file}} worked successfully.
Checked there are no open pull requests for the same cask.
Checked the cask was not already refused in closed issues.
Checked the cask is submitted to the correct repo.


          Add Lepton.app v1.2.0

e5fb934

YuerLee mentioned this pull request

homebrew formula for Lepton.app ? hackjutsu/Lepton#116

Closed


          Update and rename lepton-app.rb to lepton.rb

be4a032

Member

miccal commented Mar 4, 2017

audit for lepton: warning
 - possible duplicate, cask token conflicts with Homebrew core formula:
https://github.com/Homebrew/homebrew-core/blob/master/Formula/lepton.rb

but the formula is a totally different thing.

vitorgalvao merged commit b7f8072 into Homebrew:master

Homebrew locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.