Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homebrew formula for Lepton.app ? #116

Closed
Fil opened this issue Feb 25, 2017 · 13 comments
Closed

homebrew formula for Lepton.app ? #116

Fil opened this issue Feb 25, 2017 · 13 comments
Milestone

Comments

@Fil
Copy link

Fil commented Feb 25, 2017

Please consider adding a brew formula. One issue is that brew already has https://github.com/dropbox/lepton as lepton.

@hackjutsu
Copy link
Owner

Ha-ha, it's hard to come up with a unique name .

@hackjutsu
Copy link
Owner

hackjutsu commented Feb 27, 2017

@hackjutsu hackjutsu added this to the 1.2.1 milestone Feb 27, 2017
@YuerLee
Copy link

YuerLee commented Mar 3, 2017

I think that Homebrew Cask is a better choice.

I can handle it, but I need a name that comply Homebrew Cask's rule. And this name can't be a duplicated with a homebrew formula. As @Fil said, lepton has been taken.

@hackjutsu
Copy link
Owner

What about lepton-app?

@YuerLee
Copy link

YuerLee commented Mar 4, 2017

I thought about lepton-app,but I'm afraid that this name will be confused with dropbox's lepton.

@hackjutsu
Copy link
Owner

@passerbyid

That's a good point.

We can put the homebrew/Homebrew Cask's instructions on README with the explicit name lepton-app . Users are likely to use homebrew/Homebrew Cask to install Lepton after the reading there, other than searching for our Lepton on homebrew directly.

For people trying to install Dropbox's Lepton, I don't think lepton-app would confuse them, since it's hard to associate Dropbox's Lepton with an app.

@YuerLee
Copy link

YuerLee commented Mar 4, 2017

Okay, I have sent a pull request to homebrew-cask.

Homebrew/homebrew-cask#30575

@vitorgalvao
Copy link

And this name can't be a duplicated with a homebrew formula.

We don’t have any rule that prohibits a cask and a formula from sharing a name. Additionally, the token (what you use to install) is derived from our token reference, to prevent duplicates. lepton-app would not be acceptable in this case.

The cask in Homebrew/homebrew-cask#30575 has been merged.

@Fil Fil closed this as completed Mar 4, 2017
@YuerLee
Copy link

YuerLee commented Mar 5, 2017

@vitorgalvao Thanks!

@hackjutsu
Copy link
Owner

Thank you guys!

@hackjutsu hackjutsu modified the milestones: 1.2.1, 1.2.x Mar 5, 2017
@hackjutsu
Copy link
Owner

Do we need to send a new PR for each new release?

@vitorgalvao
Copy link

vitorgalvao commented Mar 6, 2017

Do we need to send a new PR for each new release?

Yes. But if you use cask-repair it’s literally one command away. You can run in any directory or even as part of your deployment.

Run once (for installation and setup):

brew install vitorgalvao/tiny-scripts/cask-repair
cask-repair --help

Then whenever you update Lepton, you need only:

cask-repair -v {{new_version_here}} -b lepton

And it’ll do everything for you automatically, including submitting the PR.

@hackjutsu
Copy link
Owner

@vitorgalvao Nice!Thanks for your explanation:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants