Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java cask #39752

Closed
wants to merge 1 commit into from
Closed

Update java cask #39752

wants to merge 1 commit into from

Conversation

piyush1911
Copy link
Contributor

@piyush1911 piyush1911 commented Oct 17, 2017

A new jdk was released, causing the 'brew cask install java' fail

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if updating only the sha256:

  • I verified this change is legitimate How do I do that? and am providing confirmation below:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.

A new jdk was released, causing the 'brew cask install java' fail
@piyush1911
Copy link
Contributor Author

Added the check marks.

@commitay
Copy link
Contributor

Duplicate of #39751

Thanks for the PR nonetheless.

@commitay commitay closed this Oct 17, 2017
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants