Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SimSim.app 1.3.3 #42557

Merged
merged 2 commits into from
Jan 7, 2018
Merged

Add SimSim.app 1.3.3 #42557

merged 2 commits into from
Jan 7, 2018

Conversation

rtdaly
Copy link
Contributor

@rtdaly rtdaly commented Jan 6, 2018

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.

commitay
commitay suggested changes Jan 6, 2018
View reviewed changes
Casks/simsim.rb Outdated

app 'SimSim.app'

uninstall login_item: 'SimSim',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need uninstall quit: or signal:?

Copy link
Contributor Author

@rtdaly rtdaly Jan 7, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@commitay You're right I forgot the quit:

Casks/simsim.rb Outdated
kext: 'com.dsmelov.SimSim'

zap trash: [
'~/Library/Preferences/com.dsmelov.SimSim.plist',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this a single line with zap trash.

@rtdaly
Copy link
Contributor Author

rtdaly commented Jan 7, 2018

@commitay Fixed!

@vitorgalvao vitorgalvao merged commit a1fb785 into Homebrew:master Jan 7, 2018
@rtdaly rtdaly deleted the add/simsim branch January 7, 2018 06:06
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@commitay commitay commitay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rtdaly @commitay @vitorgalvao