Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSL: forward-compatible synonyms #4845

Merged
merged 1 commit into from
Jun 28, 2014

Conversation

rolandwalker
Copy link
Contributor

This makes the following stanzas available in the DSL as
synonyms to existing stanzas, with no change to existing
functionality:

  • pkg for install
  • app for link
  • suite for link
  • preflight for before_install
  • postflight for before_uninstall
  • uninstall_preflight for before_uninstall
  • uninstall_postflight for after_uninstall

References #4688

This works, but is marked WIP because we are not in a hurry,
and because I intend to add tests.

This makes the following stanzas available in the DSL as
synonyms to existing stanza, with no change to existing
functionality:
- pkg for `install`
- app for `link`
- suite for `link`
- preflight for `before_install`
- postflight for `before_uninstall`
- uninstall_preflight for `before_uninstall`
- uninstall_postflight for `after_uninstall`

References Homebrew#4688

This works, but is marked WIP because we are not in a hurry,
and because I intend to add tests.
@rolandwalker rolandwalker changed the title WIP forward-compatible DSL synonyms DSL: forward-compatible synonyms (WIP) Jun 13, 2014
@rolandwalker
Copy link
Contributor Author

On reflection, tests aren't needed, as the current test suite will provide the
same coverage after synonyms are transitioned. The one exception is suite,
because it will have alternate functionality. However, we can't test that
functionality now, because it isn't here yet.

rolandwalker added a commit that referenced this pull request Jun 28, 2014
DSL: forward-compatible synonyms (WIP)
@rolandwalker rolandwalker merged commit 743c0cf into Homebrew:master Jun 28, 2014
@rolandwalker rolandwalker deleted the dsl_aliases branch June 28, 2014 18:37
@rolandwalker rolandwalker changed the title DSL: forward-compatible synonyms (WIP) DSL: forward-compatible synonyms Jul 28, 2014
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant