Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WKO Latest #54760

Merged
merged 4 commits into from
Dec 13, 2018
Merged

Add WKO Latest #54760

merged 4 commits into from
Dec 13, 2018

Conversation

carhensi
Copy link
Contributor

After making all changes to the cask:

  • brew cask audit --download wko is error-free.
  • brew cask style --fix wko reports no offenses.
  • The commit message includes the cask’s name and version.
  • The submission is for a stable version.

Additionally, if adding a new cask:

  • Named the cask according to the [token reference].
  • brew cask install wko worked successfully.
  • brew cask uninstall wko worked successfully.
  • Checked there are no [open pull requests] for the same cask.
  • Checked the cask was not [already refused].
  • Checked the cask is submitted to [Trial].

@vitorgalvao
Copy link
Member

What does this do? Does this require some kind of hardware to function?

@vitorgalvao vitorgalvao added the awaiting user reply Issue needs response from a user. label Dec 11, 2018
@carhensi
Copy link
Contributor Author

carhensi commented Dec 13, 2018

What does this do? Does this require some kind of hardware to function?

This is a training analytics tool. It can read training data from files or the platform provided by trainingpeaks.com It does not need additional hardware to function.

Thanks for the adjustments to the rb @vitorgalvao!

@vitorgalvao vitorgalvao removed the awaiting user reply Issue needs response from a user. label Dec 13, 2018
@vitorgalvao vitorgalvao merged commit b791f88 into Homebrew:master Dec 13, 2018
@lock lock bot added the outdated label Jan 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants