Add/tweak probots configuration. #56884
Conversation
|
There’s a stray commit for |
| @@ -10,6 +10,6 @@ lockComment: false | |||
| # Limit to only `issues` or `pulls` | |||
| # only: issues | |||
| # Add a label when locking. Set to `false` to disable | |||
| lockLabel: false | |||
| lockLabel: outdated | |||
There was a problem hiding this comment.
Why the label? Seems to me locking as “resolved” should be sufficient.
There was a problem hiding this comment.
@vitorgalvao It makes it easier to quickly query for locked issues which have other labels.
There was a problem hiding this comment.
It makes it easier to quickly query for locked issues which have other labels.
Can't you just search for the other labels then?
There was a problem hiding this comment.
That doesn't allow differentiation between locked/not locked or autolocked/not autolocked from the search interface.
There was a problem hiding this comment.
For the sake of getting this merged can you agree whether this is blocking or not?
|
Updated based on comments. |
|
@MikeMcQuaid Mind removing https://github.com/Homebrew/homebrew-cask/blob/master/.github/no-response.yml?
|
@vitorgalvao I'd rather it's left to be consistent with other repos. I think it's a useful pattern to be able to adjust that separately. |
Why do other repos have that, though? I don’t think anyone in HBC particularly likes that bot. In fact, I’ll go so far as to say it’s outright useless for us, as it never acts. Issues never get the label because either:
And the only place where we do need it (PRs), it does nothing. The only reason that bot was still active was in the hopes it eventually supported our use case (PRs). Since we’re adding the |
| # Assign `resolved` as the reason for locking. Set to `false` to disable | ||
| setLockReason: false | ||
| setLockReason: resolved |
There was a problem hiding this comment.
This is causing an error in all repos. Looks like it needs to be a boolean (even though they still have that resolved comment in their example).
Also, @MikeMcQuaid, note you don’t need to PR every repo to sync these settings, we have a script for it.
There was a problem hiding this comment.
@vitorgalvao Where is the error?
There was a problem hiding this comment.
@MikeMcQuaid The bot’s opening issues: #57088
There was a problem hiding this comment.
@vitorgalvao Sorry about that, will fix.
If we're awaiting a reply from a user an an open issue to provide more information than is in the template i.e. is issue-specific. |
|
Make sure to put the label name in quotes if it contains spaces, otherwise config parsing will fail: |
|
Thanks @dessant! @vitorgalvao opened #57222 and Homebrew/homebrew-cask-versions#6821, sorry for the delay. |
This adds the other probots used by the other Homebrew taps and tweaks the
existing configuration to be consistent with the other Homebrew taps.
Feel free to disagree on any of the individual changes, I am very open to
discussion.
Once these are all addressed and this is merged I will open the agreed version
on all the other Cask taps.