DSL: change container_type to extensible container #6068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Late addition to DSL 1.0 (oversight in the roadmap) References: Homebrew#4688
|
I'm going to be a little bit bad and push this through right away so I can cut a release. |
This was referenced Sep 8, 2014
rolandwalker
added a commit
that referenced
this pull request
Sep 8, 2014
DSL: change container_type to extensible container
rolandwalker
added a commit
to rolandwalker/homebrew-cask
that referenced
this pull request
Sep 10, 2014
Copypasta error in Homebrew#6068 means that container :type never worked, because it looked for nonexistent container.formula
This was referenced Sep 10, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Late addition to DSL 1.0 (oversight in the roadmap)
References: #4688
New syntax:
This is obviously more extensible than
container_type, but I simply forgot to makethis amendment in #4688.
An example of what else might possibly be added in this stanza is renaming:
So that we wouldn't need this hack. No sure yet; just an example.
@caskroom/maintainers, as this only affects 5 Casks in the main repo, I am comfortable
pushing in this change at the last minute and including it in DSL 1.0. The chance that
a user will actually be inconvenienced is very small.