Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(adding-a-cask): fix formatting, adding more hints #61391

Merged
merged 3 commits into from
Apr 6, 2019
Merged

doc(adding-a-cask): fix formatting, adding more hints #61391

merged 3 commits into from
Apr 6, 2019

Conversation

muescha
Copy link
Contributor

@muescha muescha commented Apr 4, 2019 •
edited
Loading

changed documentation:

  • add clear difference between new-cask-name and new-cask-name-branch
  • format to see step by step commands better as bash code snippet
  • add remove of HOMEBREW_NO_AUTO_UPDATE variable

vitorgalvao
vitorgalvao suggested changes Apr 4, 2019
View reviewed changes
Copy link
Member

@vitorgalvao vitorgalvao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed on a phone. Might not have caught everything.

Nice improvements. Thank you.

doc/development/adding_a_cask.md Show resolved Hide resolved
doc/development/adding_a_cask.md Outdated Show resolved Hide resolved
doc/development/adding_a_cask.md Outdated

```bash
$ git push <my-github-username> my-new-cask
$ git push <my-github-username> my-new-cask-branch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change instances of <var> to {{var}}, for consistency with other documents.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should i also change this snippet?

shasum -a 256 <file>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

doc/development/adding_a_cask.md Outdated Show resolved Hide resolved
doc/development/adding_a_cask.md Outdated Show resolved Hide resolved
@muescha
Copy link
Contributor Author

muescha commented Apr 4, 2019

updated from comments

@vitorgalvao vitorgalvao merged commit 9d040b7 into Homebrew:master Apr 6, 2019
@muescha muescha deleted the patch-5 branch April 6, 2019 23:14
@lock lock bot added the outdated label May 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vitorgalvao vitorgalvao vitorgalvao requested changes

Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muescha @vitorgalvao