Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use postflight DSL for suppressing Move to Applications alerts #7122

Merged
merged 22 commits into from
Nov 2, 2014

Conversation

federicobond
Copy link
Contributor

No description provided.

@vitorgalvao
Copy link
Member

Is the bundle ID retrieved automatically?

@federicobond
Copy link
Contributor Author

Yes, see lib/cask/staged.rb.

@vitorgalvao
Copy link
Member

I missed the addition of the feature. This is great.

@federicobond
Copy link
Contributor Author

path-finder and alfred are the only ones using a different key. Perhaps we can add an optional :key option to suppress_move_to_applications, like so:

class PathFinder
  ...
  postflight do
    suppress_move_to_applications :key => 'kNTMoveToApplicationsFolderAlertSuppress'
  end
  ...
end

@vitorgalvao
Copy link
Member

Sounds like a good solution, yes.

federicobond added a commit that referenced this pull request Nov 2, 2014
Use postflight DSL for suppressing Move to Applications alerts
@federicobond federicobond merged commit 01efa8b into Homebrew:master Nov 2, 2014
@federicobond federicobond deleted the use-postflight-dsl branch November 2, 2014 19:24
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants