attempt to clean up launchctl plists on uninstall

[rolandwalker]

separate launchctl unload and comment that this command was intended for unloading jobs by pathname rather than bundle ID. Leave that undocumented for now as it is untested.

[jawshooah]

👍

Currently, whenever an uninstall stanza includes a :launchctl directive I see output of the form

==> Removing launchctl service <bundle_id>
==> <current_working_dir>/<bundle_id>: No such file or directory

This patch appears to fix the problem.

[jawshooah]

Scratch that. Previous comment was based on just looking at the diff.

Just checked out the changes; the plist files still aren't getting deleted, and the bundle id still shows up in the output of list_installed_launchjob_ids. I used the github Cask as a test case.

[rolandwalker]

I'll test with the github Cask (thanks), but to be clear :launchtl still means "quit process", not "delete plist". This is a little undocumented helper, added on the theory that it can't hurt.

[jawshooah]

Closes #7931 (so we can come back to this)

[jawshooah]

@rolandwalker Any updates on this? launchctl unload expects a file path rather than a bundle ID, so this change makes sense.

@phinze, any input?

[phinze]

This seems AOK to me - just needs a rebase.