Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new ask for BLEUnlock v1.10.1 #99912

Merged
merged 4 commits into from
Feb 16, 2021
Merged

Conversation

joeyhoer
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask {{cask_file}} worked successfully.
  • brew install --cask {{cask_file}} worked successfully.
  • brew uninstall --cask {{cask_file}} worked successfully.

@miccal
Copy link
Member

miccal commented Feb 16, 2021

Thank you for your contribution to homebrew-cask @joeyhoer.

Could you please try to add a zap stanza, thanks.

@miccal miccal added the awaiting user reply Issue needs response from a user. label Feb 16, 2021
@joeyhoer
Copy link
Contributor Author

@miccal I've added it!

@miccal miccal removed the awaiting user reply Issue needs response from a user. label Feb 16, 2021
@miccal
Copy link
Member

miccal commented Feb 16, 2021

Thank you @joeyhoer.

@miccal miccal merged commit 4d50a56 into Homebrew:master Feb 16, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants