Fix python3 references in python@3.10-dependent formulae
#108008
Labels
good first issue
A good candidate for your first contribution to Homebrew/homebrew-core
help wanted
Task(s) needing PRs from the community or maintainers
outdated
PR was locked due to age
Comments
carlocab
added
help wanted
6 tasks
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this issue
Aug 19, 2022
TBB has a bug in thread creation which is exposed with usage in mold. See rui314/mold#410, rui314/mold#600. We apply a patch that has been upstreamed to TBB at oneapi-src/oneTBB#824 to fix this. The patch implements a mechanism similar to one used by Go [1], and has been adopted in the Arch and OpenSUSE TBB packages. While we're here, let's align the `cmake` invocation with other formulae, fix references to `python3.10` (Homebrew#108008), and change the `-rpath` flag so that it does not require relocation when pouring a bottle (which should speed bottle pour times up slightly). [1] https://go-review.googlesource.com/c/go/+/33894/
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this issue
Aug 19, 2022
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this issue
Aug 19, 2022
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this issue
Aug 19, 2022
BrewTestBot
pushed a commit
that referenced
this issue
Aug 19, 2022
TBB has a bug in thread creation which is exposed with usage in mold. See rui314/mold#410, rui314/mold#600. We apply a patch that has been upstreamed to TBB at oneapi-src/oneTBB#824 to fix this. The patch implements a mechanism similar to one used by Go [1], and has been adopted in the Arch and OpenSUSE TBB packages. While we're here, let's align the `cmake` invocation with other formulae, fix references to `python3.10` (#108008), and change the `-rpath` flag so that it does not require relocation when pouring a bottle (which should speed bottle pour times up slightly). [1] https://go-review.googlesource.com/c/go/+/33894/ Closes #108431. Signed-off-by: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com> Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
carlocab
added a commit
to Porkepix/homebrew-core
that referenced
this issue
Aug 19, 2022
Also, clean up `python3` reference. See Homebrew#108008.
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this issue
Aug 19, 2022
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this issue
Aug 19, 2022
BrewTestBot
pushed a commit
that referenced
this issue
Aug 20, 2022
* emscripten 3.1.19 * emscripten: update resources Also, clean up `python3` reference. See #108008. * emscripten: deduplicate `std_cmake_args` Closes #108318. Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Signed-off-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
carlocab
added a commit
that referenced
this issue
Aug 20, 2022
carlocab
added a commit
that referenced
this issue
Aug 20, 2022
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this issue
Aug 20, 2022
6 tasks
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this issue
Aug 20, 2022
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this issue
Aug 20, 2022
See Homebrew#108008. Also, - we no longer need to add Python's `libexec/"bin"` to `PATH`. See Homebrew/brew#13677. - `--install-lib` is now part of `setup_install_args`. See Homebrew/brew#13533.
carlocab
pushed a commit
that referenced
this issue
Sep 12, 2022
carlocab
pushed a commit
that referenced
this issue
Sep 12, 2022
carlocab
pushed a commit
that referenced
this issue
Sep 12, 2022
carlocab
pushed a commit
that referenced
this issue
Sep 12, 2022
carlocab
pushed a commit
that referenced
this issue
Sep 12, 2022
50 tasks
|
I've split the remaining formulae to a list in #110462 to ease tracking. |
chenrui333
pushed a commit
that referenced
this issue
Sep 13, 2022
miles170
added a commit
to miles170/homebrew-core
that referenced
this issue
Sep 13, 2022
miles170
added a commit
to miles170/homebrew-core
that referenced
this issue
Sep 17, 2022
See Homebrew#108008, and also update the license.
iMichka
added a commit
to iMichka/homebrew-core
that referenced
this issue
Sep 28, 2022
danielnachun
pushed a commit
to miles170/homebrew-core
that referenced
this issue
Oct 5, 2022
danielnachun
added a commit
that referenced
this issue
Oct 6, 2022
* libtorch: fix `python3` reference. See #108008. * libtorch: add patch for build on macOS * libtorch: fix patch and remove unneeded deps * libtorch: replace patch, fix python path and cmake Co-authored-by: Michka Popoff <michkapopoff@gmail.com> Co-authored-by: danielnachun <daniel.nachun@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
and others
Formulae which depend on
python@3.10and look forpython3, either inPATHor in
python@3.10'sbindirectory will break when Python 3.11 is released inOctober. This follows from #107517, since the release of 3.11 means we will
switch
python@3.10to using thealtinstalltarget, at which point there willno longer be a
python3inpython@3.10'sbin.It would be good to have a standardised approach for this, but I'm not sure
there is one. I'll described some approaches currently in use below.
If the
python3reference is only in one of theinstallmethod or thetestblock (and not both), then it may suffice to define
in the appropriate method/block, and make sure the newly-defined
python3variable is used in succeeding calls to Python3. For examples of this, see
chapel,cython, orvolk.If the
python3reference is in both theinstallmethod andtestblock,then it may be appropriate to define a method that can be reused in both. This
approach is currently used in formulae which build with multiple versions of
Python3 in order to allow usage with multiple versions of python (e.g.
py3cairopillow, ornumpy). For formulae that don't need this, it may suffice todefine a simpler method:
Feedback on approaches welcome.
Below is a tenative list of formulae that need fixing. This was generated with
so it may miss a few formulae, or include false positives.
python3reference. #108440python3references. #108441python3reference. #108478python3references. #108479python3reference. #108502libSDL2#108503python3references. #108504python3references. #108505python3reference. #108506python3references. #109094python3references. #109095python3reference. #109667python3reference. #109096python3reference. #109097python3references. #109098python3reference. #109786python3references. #109677python3reference. #109666python3reference. #109787python3reference. #109788python3references. #109733python3reference. #110011chapelcherrytreepython3references. #109756python3references. #109974clang-formatpython3reference. #110367python3references. #109768python3reference. #109948python3reference. #110117python3reference. #109965python3references. #110358cppcmspython3reference. #109857python3references. #110365rpathformula DSL. #109093python3reference. #109945python3reference. #110366python3reference. #110013python3references. #109770python3reference. #110014python3reference. #109993python3reference. #109969python3references. #110368python3reference. #110370python3reference. #110012python3reference. #110441python3references. #109856python3references. #109767python3references. #109731python3references. #109750python3reference. #110371python3reference. #110115python3references. #109979python3reference. #110381python3reference. #109729python3reference. #110384python3references. #109862python3reference. #110385python3reference. #109980glib-utilspython3references. #109759gpgmepython3reference. #110016python3reference. #109946python3reference. #110442python3references. #109765python3reference. #109655httpstatpython3references. #110390python3references. #109758python3reference. #110440python3references. #109678python3reference. #109958python3references. #110393python3references. #110403julialassopython3references. #110406python3reference. #110407libcap-ngpython3references. #109860libpeaspython3reference. #110408python3reference. #110409libsigrokdecodepython3reference. #110410python3reference. #109957python3references. #109832python3references. #109829python3reference. #109947python3reference. #109978python3reference. #110424python3reference. #110425python3reference. #110426mda-lv2python3reference. #109989micropythonpython3reference. #110428python3reference. #109751python3references. #109761python3reference. #109944python3reference. #110118python3references. #110120python3references. #110429rpathformula DSL. #109058python3references. #110430python3reference. #109988python3reference. #110132python@3.9reference #108269python3references. #109672python3references. #109869nodeenvpython3references. #110431python3references. #109858python3reference. #110009python3references. #109861python3reference. #109962python3reference. #109949python3references. #109663python3references. #109763python3references. #109836python3reference. #109950python3references. #109859python3references. #109766python3references. #109833pyqt@5rpathDSL. #109050python3references. #109863python3reference. #109975python3references. #109963python3reference. #109977python3reference. #109987sambapython3references. #109851python3references. #109997python3reference. #109967python3references. #109755python3reference. #109961python3reference. #110008python3references. #109976swiftpython3reference. #109880python3reference. #109728python3reference. #109879python3references. #109843python3references. #109831python3reference. #109878urhpython3references. #109726python3reference. #109877python3reference. #109887python3reference. #109888python3reference. #109889vimvirt-managerpython3references. #109876python@3.10#107645The text was updated successfully, but these errors were encountered: