-
-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
weechat 1.4 --with-ruby did not build #117
Comments
Both You can try moving your bash profile out of the way. Then check if the issue persists at that point.
Some notes about other things you mentioned:
|
Hi there, By now I have fixed the issue - I do imagine to believe that I posted this, but for some reason I haven't. Basically, I've manually put the links to the missing ruby files into the archive's make file, re-zipped it, brew edit weechat-ed and brewed with my own archive.
export PATH="/Users/manavortex/.rbenv/versions/2.2.3/include/ruby-2.2.0/ruby:$PATH"
As I said - for the sake of OCD. :) Moving my .bash_profile out of the way didn't solve it either: |
You should try with a new user. |
@manavortex OK, try with an empty brew installation, then.
|
I wonder if OP's logs reference pretty consistently this sort of thing during
Where the two Ruby header references are tossed, but none are re-added. That could explain why build goes from being able to find it to suddenly
Interestingly I can get a failure (even if not this failure) if I punt Homebrew's Ruby to the front of the @manavortex Do you have |
Doesn't seem to be OP's problem but I can't get |
@DomT4 I cannot reproduce what you're describing: And
|
@manavortex Did you try with the empty brew installation? |
Not yet - I’ll try tomorrow, okay? :) On 10 Apr 2016, at 9:03, ilovezfs wrote:
|
@manavortex Sounds good. |
What's in your |
In this case I think it may be relevant.
I can reproduce on my machine by:
Seems like the thing to do is to have Might need to add a Ruby dependency to this formula, too, to get it to build against a brewed Ruby under superenv. |
Well, |
@ilovezfs: It did not build. :D https://gist.github.com/baa2236e53631d612db942a4ee8b2b82 @apjanke: Did you check out my "fix" in the OP? I suppose that might give someone who really knows what they are doing instead of just blindly poking around in sources some additional insight into the problem. |
@manavortex Do you intentionally still have that fink installation?
|
@ilovezfs - that did it! 👍 |
Here is a fix to the formula to prevent it from picking up the Fink-installed Ruby. This gets it to build okay against the system
I think it's probably a related issue: the CMake code it uses to detect Ruby does not actually find the brewed Fiddling a bit more with CMAKE env variables that |
@apjanke Hmm ... isn't this something we should actually address in superenv instead? |
I'm not scared when it comes to digging into source code head first, but I think this might make some of the more reluctant users quite scared. A fix would be appreciated. :) |
Probably, but I don't know if we can fully. I can't tell where it's getting the Anybody know CMake well enough to know how it's choosing to look in At any rate, the I'll hack on this some more tomorrow. But I think there's an upstream bug report in here even if we can get it tamped down using |
I have no idea concerning CMake, but my dirty fix included editing a |
Oh, here we go, I think.
And here are the hardcoded Fink and MacPorts paths in
I bet that's where
Here's a problem with setting
The HINTS option is how the library paths associated with the located Maybe we should be setting This is also complicated by the fact that their cmake files prefer I've hacked the I'm pretty sure the Ruby detection logic in |
Let's try to get it working with the CMake build system first. Hacking the generated Makefile is going to be brittler. |
@apjanke I think we should probably make this test more sensitive: https://github.com/Homebrew/brew/blob/master/Library/Homebrew/os/mac.rb#L204-L235 Or at least add a more sensitive version of it to |
@manavortex It seems that the reason you didn't get a warning at the very beginning from both |
Actually, I have no idea - I’ve not installed fink since I’m running
|
@manavortex Do you mind posting the output of |
@ilovezfs Not at all, here you go:
|
@manavortex Well the mystery is why /sw/bin/fink isn't in that list. If it had been, the problem would have been flagged by brew from the very beginning, but I think we can close this because that should be a highly unusual situation. If you can recall what could have happened to /sw/bin/fink, that would be good to know. |
@DomT4: I can't reproduce the |
I posted an upstream issue report: weechat/weechat#714 |
Yeah, I think we can close this too: it's an unusual situation, and OP's problem has been worked around. Sound good, @manavortex? I've posted the general form of the CMake/Fink interaction issue at Homebrew/brew#72 so we can track and eventually fix it, But it's a separate issue so it focuses on the structural problem, and won't spam manavortex with updates about the core code that aren't relevant to this particular installation problem. |
Fix that worked
mkdir ~/Documents/fink-2016-04-11
sudo mv /sw ~/Documents/fink-2016-04-11
brew reinstall --with-ruby weechat
Dirty fix that also worked
cd /Library/Caches/Homebrew
tar -zxvf weechat-1.4.tar.gz
locate ruby.h
nano weechat-1.4/src/plugins/ruby/CMakeLists.txt
added path where ruby.h lived via include_directories($path) after if(RUBY_FOUND)
tar -zcvf weechat-1.4.tar.gz weechat-1.4
try reinstalling, insert "actual" checksum with brew edit weechat
tried again reinstalling, same game for the next error...
rinse and repeat until compiles
Bug reports:
Weechat with Ruby fails to build:
brew gist-logs weechat
#1: https://gist.github.com/anonymous/5caa7b6985d674e6b398e74567b2c69f
#2: https://gist.github.com/anonymous/6f0c14238ec2a3a866312c4ba51ba9ad
#3 https://gist.github.com/anonymous/fe427768d84d0c95facdfe33cb48b53a
#4
Attempted solutions (chronological order):
http://stackoverflow.com/a/19026248 (I've always wanted emacs anyway)brew install ncurses && brew link ncurses --forceFormula Requests:
My OCD would appreciate a fix for
The text was updated successfully, but these errors were encountered: