tectonic 0.1.6 (new formula) #14575

iKevinY · 2017-06-14T06:00:30Z

Have you followed the guidelines for contributing?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Thanks to #14490 getting merged in, we're closer to a functional formula for Tectonic! I'm submitting this as a WIP to move Homebrew-specific discussion out of tectonic-typesetting/tectonic#4, but there's a couple of things that need still need to be addressed:

Ideally, the test block should invoke tectonic. Unfortunately, a bunch of rather large TeX packages need to be downloaded in order to process even a minimal (empty) document.
brew audit fails because the harfbuzz dependency needs to be installed with-graphite2.

ilovezfs · 2017-06-14T08:38:33Z

@iKevinY this will take care of harfbuzz: #14583

ilovezfs · 2017-06-14T08:41:32Z

@iKevinY regarding the audit

Dependency 'icu4c' may be unnecessary as it is provided by macOS; try to build this formula without it.

Have you tested a build that doesn't depend on the icu4c formula?

ilovezfs · 2017-06-14T09:08:19Z

@iKevinY the build fails on Yosemite, and also fails on El Capitan unless I have Xcode not just the CLT.

ilovezfs · 2017-06-14T09:11:47Z

@iKevinY I tried it with paper.tex from the repo, and it seems to error out: https://gist.github.com/ilovezfs/befd84e087fad9c72422e90b09418b70

iMac-TMP:footec joe$ tectonic paper.tex 
note: this is a BETA release; report issues at https://github.com/tectonic-typesetting/tectonic/issues
Running TeX ...
error: something bad happened inside TeX; its output follows:

===============================================================================
(paper.tex
LaTeX2e <2016/03/31>
Babel <3.9r> and hyphenation patterns for 83 language(s) loaded.
(aastex6.cls

LaTeX Warning: You have requested document class `aastex6',
               but the document class provides `aastex'.

Document Class: aastex 2016/02/16 1.0/AAS markup document class
(times.sty) (lineno.sty) (revtex4-1.cls
Document Class: revtex4-1 2010/07/25/20:33:00 4.1r (http://publish.aps.org/revt
ex4/ for documentation)
ltxutil[2010/07/25/20:33:00 4.1r utilities package (portions licensed from W. E
. Baxter web at superscript.com)]
ltxfront[2010/07/25/20:33:00 4.1r frontmatter package (AO,DPC)]
ltxgrid[2010/07/25/20:33:00 4.1r page grid package (portions licensed from W. E
. Baxter web at superscript.com)]

Class revtex4-1 Warning: Failed to recognize \@vspace, \@vspacer, \@no@pgbk, \@
newline, and \\; no patches applied. Please get a more up-to-date class, .

(aps4-1.rtx) (aps10pt4-1.rtx) (textcase.sty) (url.sty) (natbib.sty)
(revsymb4-1.sty)) (latexsym.sty) (graphicx.sty (keyval.sty) (graphics.sty
(trig.sty) (graphics.cfg) (xetex.def (infwarerr.sty) (ltxcmds.sty))))
(amssymb.sty (amsfonts.sty)) (epsf.sty
This is `epsf.tex' v2.7.4 <14 February 2011>
) (longtable.sty) (hyperref.sty (hobsub-hyperref.sty (hobsub-generic.sty))
(ifxetex.sty) (auxhook.sty) (kvoptions.sty) (pd1enc.def) (hyperref.cfg))

Package hyperref Message: Driver (autodetected): hxetex.

(hxetex.def (puenc.def) (stringenc.sty) (rerunfilecheck.sty)) (xcolor.sty
(color.cfg)) (array.sty) (ulem.sty))===============================================================================

error: failed to open input file "mode"

iKevinY · 2017-06-15T05:14:01Z

this will take care of harfbuzz: #14583

Great, thanks!

Have you tested a build that doesn't depend on the icu4c formula?

Even when removing the explicit icu4c dependency from the formula, it still gets downloaded as part of the installation process (presumably because harfbuzz depends on it).

Maybe @pkgw has some insights into the build failures and TeX errors.

ilovezfs · 2017-06-24T08:51:45Z

@iKevinY any updates here?

iKevinY · 2017-06-25T22:51:15Z

@ilovezfs I'll post on Tectonic's forum to see if anyone has suggestions on how to fix these issues.

alexreg · 2017-06-27T00:55:09Z

@ilovezfs Did you have any more luck with a minimal tex file?

ilovezfs · 2017-06-27T01:55:02Z

@alexreg Correct. It did work with a minimal tex file when had I tried that, just not for the paper.tex in the tectonic repo.

the build fails on Yosemite, and also fails on El Capitan unless I have Xcode not just the CLT.

That is probably a higher priority problem than getting paper.tex to work :)

pkgw · 2017-06-27T12:23:18Z

Sorry, I'm really slammed at work right now and haven't been able to spend any time on this. Unfortunately it looks like this will continue to be the case for the next few weeks at least.

ilovezfs · 2017-06-27T12:28:06Z

@pkgw no worries! Thanks for the status update.

alexreg · 2017-06-28T22:29:31Z

Just a note: the rust dependency should be optional, to allow for e.g. rustup versions of Rust.

depends_on "rust" => [:build, :recommended]

pkgw · 2017-07-08T15:03:58Z

Heads up: I've just published version 0.1.6 of the Tectonic rust crate.

ilovezfs · 2017-07-08T15:13:34Z

@pkgw neat! Note that https://github.com/tectonic-typesetting/tectonic/releases/latest still points to 0.1.5

pkgw · 2017-07-08T15:14:47Z

@ilovezfs Yeah — will update that after I write up a release announcement.

ilovezfs · 2017-07-08T15:16:38Z

@iKevinY would be cool to get the Homebrew formula into the release notes :) Wonder if we should just depends_on :el_capitan it for now.

pkgw · 2017-07-08T15:26:48Z

@iKevinY @ilovezfs There's a ton to write for the release notes and I need to revamp the website a bit too, so you probably have some time :-)

Oh, and I need to update my Conda packages, which involves rebuilding my packages of the Rust/Cargo toolchain ...

ilovezfs · 2017-07-08T15:28:38Z

@pkgw I'm still seeing this for paper.tex

iMac-TMP:paper joe$ tectonic paper.tex 
note: this is a BETA release; ask questions and report bugs at https://tectonic.newton.cx/
note: indexing https://purl.org/net/pkgwpub/tectonic-default
note: resolved to https://dl.bintray.com/pkgw/tectonic/tl2016extras/2016.0r4/tlextras-2016.0r4.tar
note: downloading SHA256SUM
note: generating format "latex"
Running TeX ...
error: something bad happened inside TeX; its output follows:

===============================================================================
(paper.tex
LaTeX2e <2016/03/31>
Babel <3.9r> and hyphenation patterns for 83 language(s) loaded.
(aastex6.cls

LaTeX Warning: You have requested document class `aastex6',
               but the document class provides `aastex'.

Document Class: aastex 2016/02/16 1.0/AAS markup document class
(times.sty) (lineno.sty) (revtex4-1.cls
Document Class: revtex4-1 2010/07/25/20:33:00 4.1r (http://publish.aps.org/revt
ex4/ for documentation)
ltxutil[2010/07/25/20:33:00 4.1r utilities package (portions licensed from W. E
. Baxter web at superscript.com)]
ltxfront[2010/07/25/20:33:00 4.1r frontmatter package (AO,DPC)]
ltxgrid[2010/07/25/20:33:00 4.1r page grid package (portions licensed from W. E
. Baxter web at superscript.com)]

Class revtex4-1 Warning: Failed to recognize \@vspace, \@vspacer, \@no@pgbk, \@
newline, and \\; no patches applied. Please get a more up-to-date class, .

(aps4-1.rtx) (aps10pt4-1.rtx) (textcase.sty) (url.sty) (natbib.sty)
(revsymb4-1.sty)) (latexsym.sty) (graphicx.sty (keyval.sty) (graphics.sty
(trig.sty) (graphics.cfg) (xetex.def (infwarerr.sty) (ltxcmds.sty))))
(amssymb.sty (amsfonts.sty)) (epsf.sty
This is `epsf.tex' v2.7.4 <14 February 2011>
) (longtable.sty) (hyperref.sty (hobsub-hyperref.sty (hobsub-generic.sty))
(ifxetex.sty) (auxhook.sty) (kvoptions.sty) (pd1enc.def) (hyperref.cfg))

Package hyperref Message: Driver (autodetected): hxetex.

(hxetex.def (puenc.def) (stringenc.sty) (rerunfilecheck.sty)) (xcolor.sty
(color.cfg)) (array.sty) (ulem.sty))===============================================================================

error: failed to open input file "mode"

ilovezfs · 2017-07-08T15:29:10Z

Is there a basic doc you like to test with it?

pkgw · 2017-07-08T15:30:38Z

@ilovezfs That's the one that I use. That's a strange failure, since the input file mode.tex should just be sitting right in the tests/xenia directory.

pkgw · 2017-07-08T17:13:49Z

Hmm, looks like some C++ standard library versioning issue. Maybe something like needing to link with libc++ instead of libstdc++, that sort of thing? I'm not familiar with the details here but I bet some Googling will reveal people who have grappled with the same problem.
This is a bit of cargo-cult on my part but as far as I can tell it's needed. See this lengthy GitHub issue.
It does seem reasonable to avoid this. The Tectonic source tree includes all of the files needed to build the plain format, which is built and exercised in the standard test suite. If you're running the built-in tests with cargo test I don't think it's necessary to also run the xenia test.

ilovezfs · 2017-07-08T17:14:01Z

You misunderstand. If it's a :recommended dependency, then it allows users who use Rustup rust to bypass installing a Homebrew Rust, which is advantageous.

rustup's rust won't be in the PATH. And it's not a concern because rust is a build-time only requirement anyway, so people who pour the pre-built bottle binary have nothing to worry about.

pkgw · 2017-07-08T17:14:51Z

@alexreg Strange! There is definitely nothing in Tectonic that has anything to do with sqlite, so it must be something on the Homebrew side.

ilovezfs · 2017-07-08T17:15:14Z

Error: /usr/local/opt/sqlite not present or broken

This is a problem with your brew installation. Probably just need to

rm /usr/local/opt/sqlite
rm -rf /usr/local/Cellar/sqlite
brew prune
brew install sqlite

alexreg · 2017-07-08T17:16:28Z

Hmm, looks like some C++ standard library versioning issue. Maybe something like needing to link with libc++ instead of libstdc++, that sort of thing? I'm not familiar with the details here but I bet some Googling will reveal people who have grappled with the same problem.

Yes, looks like exactly that. C++11 vs. C++.

alexreg · 2017-07-08T17:18:15Z

You misunderstand. If it's a :recommended dependency, then it allows users who use Rustup rust to bypass installing a Homebrew Rust, which is advantageous.
rustup's rust won't be in the PATH. And it's not a concern because rust is a build-time only requirement anyway, so people who pour the pre-built bottle binary have nothing to worry about.

It's still extra disk-space, which is non-ideal. But I see your point about PATH. (Well, it may be in the PATH, but not necessarily.) Ideally we'd have something like :rust, but I know the Homebrew maintainer is strongly against these things, for some odd reason, which I forget.

It's also annoying that Homebrew Rust conflicts with Rustup Rust...

Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink etc/bash_completion.d/cargo
Target /usr/local/etc/bash_completion.d/cargo
already exists. You may want to remove it:
  rm '/usr/local/etc/bash_completion.d/cargo'

To force the link and overwrite all conflicting files:
  brew link --overwrite rust

To list all files that would be deleted:
  brew link --overwrite --dry-run rust

Possible conflicting files are:
/usr/local/etc/bash_completion.d/cargo
/usr/local/share/zsh/site-functions/_cargo

ilovezfs · 2017-07-08T17:18:20Z

If you're running the built-in tests with cargo test I don't think it's necessary to also run the xenia test.

@pkgw we cannot run cargo test in the test block because the build-time-only rust dependency will be unavailable at that point.

pkgw · 2017-07-08T17:23:09Z

@ilovezfs Ah, I see. If small downloads are acceptable, you could test with a nonsense document that uses the plain format, which requires many fewer resources. If you really want to avoid any downloads at all, that's trickier ... the distribution could perhaps embed a tiny bundle file with the resources needed to create the plain format.

I'm going to be offline for a while starting now. I still need to write the release notes so the announcement is very unlikely to go out before tomorrow at this rate.

alexreg · 2017-07-08T17:24:58Z

Just want to confirm: all builds fine for me now! (Please see above post still though.)

ilovezfs · 2017-07-08T17:27:57Z

Just want to confirm: all builds fine for me now!

excellent!

ilovezfs · 2017-07-08T17:28:30Z

I'm going to be offline for a while starting now. I still need to write the release notes so the announcement is very unlikely to go out before tomorrow at this rate.

hehe feel free to blame me :)

ilovezfs · 2017-07-08T17:35:19Z

OK. The build failure is fixed by adding

    ENV.cxx11
    ENV["MACOSX_DEPLOYMENT_TARGET"] = MacOS.version

ilovezfs · 2017-07-08T18:14:49Z

I am more than happy to review a PR for a lighter-weight, or even offline test, but I think this is good to ship now.

iKevinY · 2017-07-08T18:30:56Z

Oh wow, what a nice surprise to see when checking my GitHub notifications! Thank you to everyone for getting this formula working! 😄

ilovezfs · 2017-07-08T18:43:37Z

Thanks for the 🆕 formula @iKevinY! Shipped!

Also, thanks @pkgw and @alexreg for the helping hands! It's much appreciated. :)

alexreg · 2017-07-08T19:27:44Z

Wonderful. Great work, guys!

…

Sent from my iPhone

On 8 Jul 2017, at 19:42, ilovezfs ***@***.***> wrote: Closed #14575 via f44bd68. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

pkgw · 2017-07-09T13:46:14Z

Great! I've updated the website to mention Homebrew as an option now. (Relevant commit.)

ilovezfs · 2017-07-09T13:48:04Z

@pkgw awesome! Thanks :)

ilovezfs · 2017-07-09T13:50:02Z

@pkgw note that I made --with-graphite2 the default for harfbuzz now for the sake of tectonic, so the source-build instructions on your site are slightly outdated.

ilovezfs · 2017-07-09T13:50:56Z

See #14583

pkgw · 2017-07-09T13:52:32Z

Oh, nice, thanks! Can I trouble you to submit a PR on the website repo to make the language more accurate?

ilovezfs · 2017-07-09T13:52:53Z

@pkgw I'd be happy to.

ilovezfs · 2017-07-09T14:13:42Z

@pkgw tectonic-typesetting/tectonic-typesetting.github.io#10

pkgw · 2017-07-12T13:20:45Z

@ilovezfs Re: the zlib stuff, tectonic #120 may have fixed this on our end, so you may be able to drop the zlib dependency when the next version comes out.

ilovezfs · 2017-07-12T13:31:11Z

@pkgw yes it looks like it works to me:

iMac-TMP:~ joe$ mdutil -t `which tectonic`
/usr/local/Cellar/tectonic/HEAD-8201ce1/bin/tectonic
iMac-TMP:~ joe$ brew linkage tectonic
System libraries:
  /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit
  /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
  /System/Library/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics
  /System/Library/Frameworks/CoreText.framework/Versions/A/CoreText
  /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation
  /System/Library/Frameworks/Security.framework/Versions/A/Security
  /usr/lib/libSystem.B.dylib
  /usr/lib/libc++.1.dylib
  /usr/lib/libobjc.A.dylib
  /usr/lib/libz.1.dylib
Homebrew libraries:
  /usr/local/opt/freetype/lib/libfreetype.6.dylib (freetype)
  /usr/local/opt/graphite2/lib/libgraphite2.3.dylib (graphite2)
  /usr/local/opt/harfbuzz/lib/libharfbuzz-icu.0.dylib (harfbuzz)
  /usr/local/opt/harfbuzz/lib/libharfbuzz.0.dylib (harfbuzz)
  /usr/local/opt/icu4c/lib/libicudata.58.2.dylib (icu4c)
  /usr/local/opt/icu4c/lib/libicuuc.58.dylib (icu4c)
  /usr/local/opt/libpng/lib/libpng16.16.dylib (libpng)
iMac-TMP:~ joe$ brew config | grep Xcode
Xcode: N/A
iMac-TMP:~ joe$

ilovezfs added new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Jun 14, 2017

ilovezfs mentioned this pull request Jun 14, 2017

harfbuzz: make graphite2 recommended #14583

Closed

4 tasks

ilovezfs added the build failure CI fails while building the software label Jun 14, 2017

dunn added the needs response Needs a response from the issue/PR author label Jun 14, 2017

BrewTestBot removed the needs response Needs a response from the issue/PR author label Jun 15, 2017

JCount added the needs response Needs a response from the issue/PR author label Jun 25, 2017

BrewTestBot removed the needs response Needs a response from the issue/PR author label Jun 25, 2017

iKevinY mentioned this pull request Jun 25, 2017

Improve installation story: pre-built packages, easy builds tectonic-typesetting/tectonic#4

Closed

1 task

ilovezfs changed the title ~~tectonic 0.1.5 (new formula)~~ tectonic 0.1.6 (new formula) Jul 8, 2017

ilovezfs approved these changes Jul 8, 2017

View reviewed changes

tectonic 0.1.6 (new formula)

163219e

ilovezfs closed this in f44bd68 Jul 8, 2017

iKevinY deleted the tectonic branch July 8, 2017 19:48

Homebrew locked and limited conversation to collaborators May 4, 2018

tectonic 0.1.6 (new formula) #14575

tectonic 0.1.6 (new formula) #14575

Conversation

iKevinY commented Jun 14, 2017 • edited by ilovezfs Loading

ilovezfs commented Jun 14, 2017

ilovezfs commented Jun 14, 2017

ilovezfs commented Jun 14, 2017

ilovezfs commented Jun 14, 2017

iKevinY commented Jun 15, 2017

ilovezfs commented Jun 24, 2017

iKevinY commented Jun 25, 2017

alexreg commented Jun 27, 2017

ilovezfs commented Jun 27, 2017

pkgw commented Jun 27, 2017

ilovezfs commented Jun 27, 2017

alexreg commented Jun 28, 2017 • edited Loading

pkgw commented Jul 8, 2017

ilovezfs commented Jul 8, 2017

pkgw commented Jul 8, 2017

ilovezfs commented Jul 8, 2017

pkgw commented Jul 8, 2017 • edited Loading

ilovezfs commented Jul 8, 2017

ilovezfs commented Jul 8, 2017

pkgw commented Jul 8, 2017

pkgw commented Jul 8, 2017

ilovezfs commented Jul 8, 2017

pkgw commented Jul 8, 2017

ilovezfs commented Jul 8, 2017 • edited Loading

alexreg commented Jul 8, 2017

alexreg commented Jul 8, 2017 • edited Loading

ilovezfs commented Jul 8, 2017

pkgw commented Jul 8, 2017

alexreg commented Jul 8, 2017 • edited Loading

ilovezfs commented Jul 8, 2017

ilovezfs commented Jul 8, 2017

ilovezfs commented Jul 8, 2017

ilovezfs commented Jul 8, 2017

iKevinY commented Jul 8, 2017

ilovezfs commented Jul 8, 2017

alexreg commented Jul 8, 2017 via email

pkgw commented Jul 9, 2017

ilovezfs commented Jul 9, 2017

ilovezfs commented Jul 9, 2017 • edited Loading

ilovezfs commented Jul 9, 2017 • edited Loading

pkgw commented Jul 9, 2017

ilovezfs commented Jul 9, 2017

ilovezfs commented Jul 9, 2017

pkgw commented Jul 12, 2017

ilovezfs commented Jul 12, 2017

iKevinY commented Jun 14, 2017 •

edited by ilovezfs

Loading

alexreg commented Jun 28, 2017 •

edited

Loading

pkgw commented Jul 8, 2017 •

edited

Loading

ilovezfs commented Jul 8, 2017 •

edited

Loading

alexreg commented Jul 8, 2017 •

edited

Loading

alexreg commented Jul 8, 2017 •

edited

Loading

ilovezfs commented Jul 9, 2017 •

edited

Loading

ilovezfs commented Jul 9, 2017 •

edited

Loading