Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lumo 1.2.0 #10169

Closed
wants to merge 2 commits into from
Closed

lumo 1.2.0 #10169

wants to merge 2 commits into from

Conversation

anmonteiro
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@anmonteiro
Copy link
Contributor Author

anmonteiro commented Feb 21, 2017

I think CI is failing with the same issue reported in nodejs/node#11104. This project builds Node (7.5.0) as part of the release process. I wonder what a solution might be?

@JCount JCount added the clock_gettime CI fails due to clock_gettime symbol label Feb 22, 2017
@anmonteiro
Copy link
Contributor Author

Looks like Node 7.6.0 is out and fixes the clock_gettime issue. Is it worth the trouble fixing the build on this PR or should I just make a new release with the new version?

@MikeMcQuaid
Copy link
Member

Can this project not be made to use the node formula instead?

@anmonteiro
Copy link
Contributor Author

anmonteiro commented Feb 22, 2017

I don't think that's going to be possible. The project uses Nexe to compile a single binary. This resulting binary is a slightly modified version of the Node.js build (with a custom init script to land users on a ClojureScript REPL).

For that reason we need to be able to build Node.js ourselves.

@ilovezfs
Copy link
Contributor

ilovezfs commented Mar 7, 2017

@anmonteiro mind creating a new release now that 7.7.1 is out?

@anmonteiro
Copy link
Contributor Author

I'll do that. We don't need this anymore. Thanks.

@anmonteiro anmonteiro closed this Mar 7, 2017
@ilovezfs
Copy link
Contributor

ilovezfs commented Mar 7, 2017

Cool. Thank you!

@anmonteiro anmonteiro deleted the patch-1 branch March 7, 2017 19:43
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
clock_gettime CI fails due to clock_gettime symbol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants