initial ctop formula

[avelino]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

bcicen/ctop#5

[bfontaine]

For the future pull-requests please follow our guidelines for contributing and use the commit format ctop 0.4.1 (new formula). Thanks!

[bfontaine]

We need to build from source here.

[bfontaine]

Don’t use mv + bin.install. See my comment on your other PR: #10847 (comment)

[bfontaine]

You can merge this line and the one above by using system "go", "build", "-o", bin/"ctop".

[avelino]

Awaiting project solve that problem to send update for homebrew: bcicen/ctop#33

PR on ctop to fixed problem: bcicen/ctop#34 (awaiting approval)

[fxcoudert]

  * `bottle modifier` (line 8) should be put before `depends_on` (line 7)
  * C: 7: col 14: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

[bfontaine]

This -deps confuses the version parser; please add the version below this line using version "0.4.1".

Error: 1 problem in 1 formula
ctop:
  * Stable: version (deps) is set to a string without a digit

[avelino]

@bcicen pls

[bcicen]

@avelino - as @bfontaine's comment suggests, all you need to do is insert

version "0.4.1"

below line 4 in the current formula

[avelino]

@bcicen
Formula:

class Ctop < Formula
  desc "Top-like interface for container metrics"
  homepage "https://bcicen.github.io/ctop/"
  version "0.4.1"
  url "https://github.com/bcicen/ctop/archive/v0.4.1-deps.tar.gz"
  sha256 "bc10b774dad0bc7ef0be41bcfb36c774fc28dafa789b2f43f1ecdb5b75390867"

  depends_on "go" => :build
  depends_on "glide" => :build

  def install
    ENV["GOPATH"] = buildpath
    ENV["GLIDE_HOME"] = HOMEBREW_CACHE/"glide_home/#{name}"
    dir = buildpath/"src/github.com/bcicen/ctop"
    dir.install Dir["*"]
    cd dir do
      system "glide", "install"
      system "go", "build", "-o", bin/"ctop"
    end
  end

  test do
    system "#{bin}/ctop", "-v"
  end
end

Error:

$ brew install --build-from-source Formula/ctop.rb
==> Downloading https://github.com/bcicen/ctop/archive/v0.4.1-deps.tar.gz
Already downloaded: /Users/avelino/Library/Caches/Homebrew/ctop-0.4.1.tar.gz
==> glide install
Last 15 lines from /Users/avelino/Library/Logs/Homebrew/ctop/01.glide:
2017-03-13 11:11:42 -0300

glide
install

[ERROR] Failed to find glide.yaml file in directory tree: Cannot resolve parent of /

Do not report this issue to Homebrew/brew or Homebrew/core!

These open issues may also help:
initial ctop formula https://github.com/Homebrew/homebrew-core/pull/10846

[avelino]

@bcicen Will generate new release?

[bcicen]

@avelino you need to clear your local cache before testing the brew install again to fetch the correct version:

rm -rvf /Users/avelino/Library/Caches/Homebrew/ctop*

[bcicen]

@avelino version needs to be on line 5, below url. Test error:
* `url` (line 5) should be put before `version` (line 4)

[fxcoudert]

Thanks @avelino for your contribution to Homebrew!