Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stepci 2.1.0 (new formula) #113109

Closed
wants to merge 1 commit into from
Closed

Conversation

muffl0n
Copy link
Contributor

@muffl0n muffl0n commented Oct 14, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

See stepci/stepci#24

@BrewTestBot BrewTestBot added new formula PR adds a new formula to Homebrew/homebrew-core nodejs Node or npm use is a significant feature of the PR or issue labels Oct 14, 2022
@chenrui333
Copy link
Member

Have you ensured that your commits follow the commit style guide?

@muffl0n thanks for the PR, can you amend your commit message as specified in the style guide?

@chenrui333 chenrui333 changed the title stepci: add initial formula stepci 2.1.0 (new formula) Oct 14, 2022
Formula/stepci.rb Outdated Show resolved Hide resolved
@muffl0n
Copy link
Contributor Author

muffl0n commented Oct 15, 2022

Thank you very much for your detailed feedback! Gonna have a look when I'm back at the office.

@muffl0n
Copy link
Contributor Author

muffl0n commented Oct 19, 2022

can you amend your commit message

Done. I hope it fits the guide now. :)

end

test do
assert true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a better test than assert true

@cho-m cho-m added the needs response Needs a response from the issue/PR author label Nov 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Dec 5, 2022
@chenrui333
Copy link
Member

ping @muffl0n

@muffl0n
Copy link
Contributor Author

muffl0n commented Dec 7, 2022

Sorry for the silence. Unfortunately I do not have the chance to work on this atm.

@muffl0n muffl0n closed this Dec 7, 2022
@chenrui333 chenrui333 mentioned this pull request Dec 25, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs response Needs a response from the issue/PR author new formula PR adds a new formula to Homebrew/homebrew-core nodejs Node or npm use is a significant feature of the PR or issue stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants