Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formula for Homebrew #24

Closed
muffl0n opened this issue Oct 14, 2022 · 11 comments
Closed

Formula for Homebrew #24

muffl0n opened this issue Oct 14, 2022 · 11 comments
Labels
help wanted Extra attention is needed

Comments

@muffl0n
Copy link

muffl0n commented Oct 14, 2022

It would be awesome to have a formula for Homebrew.

@mishushakov mishushakov added the help wanted Extra attention is needed label Oct 14, 2022
@mishushakov
Copy link
Member

I'm a Mac user myself and would love this, but I don't know how to add formulas to Homebrew
Would you be able to help us out? We're good at accepting Pull Requests 😄

@muffl0n
Copy link
Author

muffl0n commented Oct 14, 2022

Gave it a try (with the help of https://github.com/zmwangx/homebrew-npm-noob): Homebrew/homebrew-core#113109

@mishushakov
Copy link
Member

Amazing, thanks! I'll monitor the PR and add brew as installation option once they merge!

@muffl0n
Copy link
Author

muffl0n commented Oct 15, 2022

They are asking for a test case. Could you help me out with that? I'm not confident enough with stepci to know what would be appropriate.

@mishushakov
Copy link
Member

Sure! What I understand is we need to run some test to verify the software runs as expected
We could create a temporary test file, run it using the cli and verify the outputs

If this doesn't work within a brew script, I'll implement this as a test command on the CLI

@muffl0n
Copy link
Author

muffl0n commented Oct 15, 2022

Thanks for helping out!

@mishushakov
Copy link
Member

Hello, @muffl0n
Any progress you can share with the community? Do you need any input from me to get this going?

Let me know 😉

@muffl0n
Copy link
Author

muffl0n commented Oct 19, 2022

I still didn't find the time to learn how to write a test for the formula. So if you have an idea how to do that, let me know! :)

@mishushakov
Copy link
Member

Ok, thanks for update! I don't have time to get into that right now, but I will let you know if I have something 😉

@chenrui333
Copy link
Contributor

This issue can be closed now.

$ brew install stepci
==> Fetching stepci
==> Downloading https://ghcr.io/v2/homebrew/core/stepci/manifests/2.6.0
######################################################################## 100.0%
==> Downloading https://ghcr.io/v2/homebrew/core/stepci/blobs/sha256:1e41ea796ca2e6cae06d78d88a3c164906c7c0a64249
==> Downloading from https://pkg-containers.githubusercontent.com/ghcr1/blobs/sha256:1e41ea796ca2e6cae06d78d88a3c
######################################################################## 100.0%
==> Pouring stepci--2.6.0.arm64_ventura.bottle.tar.gz
🍺  /opt/homebrew/Cellar/stepci/2.6.0: 9,296 files, 37.5MB

@muffl0n
Copy link
Author

muffl0n commented Dec 26, 2022

Thank you!

@muffl0n muffl0n closed this as completed Dec 26, 2022
mishushakov pushed a commit that referenced this issue Dec 30, 2023
mishushakov pushed a commit that referenced this issue Dec 30, 2023
mishushakov pushed a commit that referenced this issue Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants