New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minikube formula #12189
Add minikube formula #12189
Conversation
end | ||
|
||
test do | ||
system "minikube" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the full path instead: bin/"minikube"
|
||
def install | ||
mv "minikube-darwin-amd64", "minikube" | ||
bin.install "minikube" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use bin.install "foo" => "bar"
to do the equivalent of mv "foo", "bar"; bin.install "bar"
.
class Minikube < Formula | ||
desc "Run Kubernetes locally" | ||
homepage "https://github.com/kubernetes/minikube" | ||
url "https://github.com/kubernetes/minikube/releases/download/v0.17.1/minikube-darwin-amd64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to build from source here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my ignorance, couldn't we do something like OS.mac? ? MAC_URL : LINUX_URL
. Or is there a reason to build from source other than OS compatibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formula must build from source.
Note that there is already a cask for Minikube:
|
Let’s close this PR, then. |
With respect, why is Minikube a cask application? Unless I misunderstood something, the purpose of cask is for GUI applications, which Minikube is not. Second, and more importantly, you are leaving out the community of Linuxbrew users, who can't use cask, but would like to install Minikube via some kind of package management. Can this be reopened? I would be happy to take it over. |
@chases Feel free to open a new PR that builds |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?