Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minikube formula #12189

Closed
wants to merge 3 commits into from
Closed

Add minikube formula #12189

wants to merge 3 commits into from

Conversation

bonifaido
Copy link
Contributor

@bonifaido bonifaido commented Apr 7, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@bfontaine bfontaine added the new formula PR adds a new formula to Homebrew/homebrew-core label Apr 7, 2017
end

test do
system "minikube"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the full path instead: bin/"minikube"


def install
mv "minikube-darwin-amd64", "minikube"
bin.install "minikube"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use bin.install "foo" => "bar" to do the equivalent of mv "foo", "bar"; bin.install "bar".

class Minikube < Formula
desc "Run Kubernetes locally"
homepage "https://github.com/kubernetes/minikube"
url "https://github.com/kubernetes/minikube/releases/download/v0.17.1/minikube-darwin-amd64"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to build from source here.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my ignorance, couldn't we do something like OS.mac? ? MAC_URL : LINUX_URL. Or is there a reason to build from source other than OS compatibility?

Copy link
Contributor

@commitay commitay Apr 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formula must build from source.

https://docs.brew.sh/Acceptable-Formulae

@ilovezfs ilovezfs added the needs response Needs a response from the issue/PR author label Apr 19, 2017
@BrewTestBot BrewTestBot removed the needs response Needs a response from the issue/PR author label Apr 26, 2017
@eneveu
Copy link

eneveu commented May 4, 2017

Note that there is already a cask for Minikube:

 ~/code > brew cask info minikube
minikube: 0.18.0
https://github.com/kubernetes/minikube
Not installed
From: https://github.com/caskroom/homebrew-cask/blob/master/Casks/minikube.rb
==> Name
Minikube
==> Artifacts
minikube-darwin-amd64 (binary)

@bfontaine
Copy link
Contributor

Let’s close this PR, then.

@bfontaine bfontaine closed this May 4, 2017
@chases
Copy link

chases commented Apr 27, 2018

With respect, why is Minikube a cask application? Unless I misunderstood something, the purpose of cask is for GUI applications, which Minikube is not.

Second, and more importantly, you are leaving out the community of Linuxbrew users, who can't use cask, but would like to install Minikube via some kind of package management.

Can this be reopened? I would be happy to take it over.

@commitay
Copy link
Contributor

@chases Feel free to open a new PR that builds minikube from source.

@chases chases mentioned this pull request May 4, 2018
4 tasks
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants