minikube 0.26.1 (new formula) #27468
Conversation
| class Minikube < Formula | ||
| desc "Tool that makes it easy to run Kubernetes locally" | ||
| homepage "https://kubernetes.io/docs/getting-started-guides/minikube/" | ||
| url "https://github.com/kubernetes/minikube.git", |
There was a problem hiding this comment.
Can we build from source archive? https://github.com/kubernetes/minikube/archive/v0.26.1.tar.gz
There was a problem hiding this comment.
The only problem with that is the make script depends on the build directory having a valid git repository.
| :tag => "v0.26.1", | ||
| :revision => "6ded2b647d1b1f62100c630bcfcc1363c631ce2d" | ||
|
|
||
| # Docker required for non-Linux builds |
There was a problem hiding this comment.
Homebrew is for macOS. Remove unless MacOS.version == Version::NULL and comment
There was a problem hiding this comment.
This formula is meant to work on Linuxbrew as well, how is that normally handled?
There was a problem hiding this comment.
Linuxbrew will handle the changes for Linux
|
|
||
| # Docker required for non-Linux builds | ||
| depends_on "docker" => :build unless MacOS.version == Version::NULL | ||
|
|
| end | ||
|
|
||
| test do | ||
| assert_match version.to_s, shell_output("#{bin}/minikube version 2>&1") |
There was a problem hiding this comment.
We need a test that exercises the some of the functionality of the app.
There was a problem hiding this comment.
If you don't mind, would you point me to an example you'd like me to follow? Lots of the formulas I looked at do more or less exactly this.
|
|
||
| cd repo_path do | ||
| system "make" | ||
| bin.install "out/minikube" => "minikube" |
There was a problem hiding this comment.
No doc, no man page, no other file to install?
| repo_path.install Dir["*"] | ||
|
|
||
| cd repo_path do | ||
| system "make" |
|
Upstream has an open issue for creating a Homebrew formula.
Currently localkube is still included but it has a PR open for it to be removed. kubernetes/minikube#2736 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Hi @chases, thanks for the pull request, we are going to close it for now. We would be happy to consider a revised formula that does not rely on |
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?Continuation of #12189