Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastfec 0.1.9 #123222

Closed
wants to merge 1 commit into from
Closed

fastfec 0.1.9 #123222

wants to merge 1 commit into from

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Feb 14, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333 chenrui333 mentioned this pull request Feb 14, 2023
@chenrui333
Copy link
Member

  Error: Failed changing install name in /opt/homebrew/Cellar/fastfec/0.1.9/bin/fastfec
    from /opt/homebrew/opt/pcre/lib/libpcre.1.dylib
      to @@HOMEBREW_PREFIX@@/opt/pcre/lib/libpcre.1.dylib

@chenrui333 chenrui333 added the build failure CI fails while building the software label Feb 14, 2023
@iMichka iMichka force-pushed the fastfec branch 3 times, most recently from 0fe7fbb to f1538c9 Compare February 15, 2023 04:08
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Feb 15, 2023
@SMillerDev
Copy link
Member

  ==> zig build -Dvendored-pcre=false --search-prefix /home/linuxbrew/.linuxbrew/opt/curl
  error: ld.lld: relocation R_X86_64_32S cannot be used against local symbol; recompile with -fPIC
      note: defined in /home/linuxbrew/.linuxbrew/Cellar/pcre/8.45/lib/libpcre.a(libpcre_la-pcre_compile.o)
      note: referenced by pcre_compile.c
      note:               libpcre_la-pcre_compile.o:(find_fixedlength) in archive 

@carlocab
Copy link
Member

Oops, didn't see that you had worked on this already. Merged in #123946.

@carlocab carlocab closed this Feb 27, 2023
@iMichka iMichka deleted the fastfec branch February 27, 2023 20:07
@iMichka
Copy link
Member Author

iMichka commented Feb 27, 2023

Thanks! No issue :)

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2023
@chenrui333 chenrui333 added the zig Zig use is a significant feature of the PR or issue label Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. outdated PR was locked due to age zig Zig use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants