Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-c: use specified version of openssl #125380

Closed
wants to merge 1 commit into from

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

In #125208 where rust is being switched to openssl@3, cargo-c reported No linkage with libssl.dylib! Cargo is likely using a vendored version. (log). It is likely using rust's openssl@3 dependency, instead of the declared openssl@1.1.

@BrewTestBot BrewTestBot added the rust Rust use is a significant feature of the PR or issue label Mar 11, 2023
@ZhongRuoyu
Copy link
Member Author

To make sure, I will rebase this and mark it as "Ready for review" after #125208 is merged.

@Porkepix
Copy link
Contributor

To make sure, I will rebase this and mark it as "Ready for review" after #125208 is merged.

Can't it be switched to openssl 3 after rust switch is merged?

@ZhongRuoyu
Copy link
Member Author

Can't it be switched to openssl 3 after rust switch is merged?

Not yet, because of libssh2. It links with openssl@1.1.

@ZhongRuoyu ZhongRuoyu mentioned this pull request Mar 11, 2023
@ZhongRuoyu
Copy link
Member Author

Actually, since #124227 revbumps cargo-c, this PR should wait for that too.

@ZhongRuoyu ZhongRuoyu deleted the cargo-c-openssl branch March 13, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants