Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust 1.68.0 #125208

Closed
wants to merge 2 commits into from
Closed

rust 1.68.0 #125208

wants to merge 2 commits into from

Conversation

ZhongRuoyu
Copy link
Member

@ZhongRuoyu ZhongRuoyu commented Mar 9, 2023

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. long build Set a long timeout for formula testing labels Mar 9, 2023
@ZhongRuoyu
Copy link
Member Author

ZhongRuoyu commented Mar 9, 2023

Was attempting openssl-3-migration Related to switching to an OpenSSL 3 dependency . It seems that cargo-outdated is the only blocker cargo-edit and cargo-outdated are the only blockers:

brew uses --eval-all --recursive rust
cargo-about
cargo-bloat
cargo-deny
cargo-edit
cargo-llvm-lines
cargo-make
cargo-nextest
cargo-release
cargo-zigbuild
maturin
brew deps --tree `brew uses --eval-all --recursive rust`

cargo-about
└── rust
├── openssl@1.1
│ └── ca-certificates
└── pkg-config

cargo-bloat
└── rust
├── openssl@1.1
│ └── ca-certificates
└── pkg-config

cargo-deny
└── rust
├── openssl@1.1
│ └── ca-certificates
└── pkg-config

cargo-edit
├── libgit2
│ └── libssh2
│ └── openssl@1.1
│ └── ca-certificates
├── openssl@1.1
│ └── ca-certificates
└── rust
├── openssl@1.1
│ └── ca-certificates
└── pkg-config

cargo-llvm-lines
└── rust
├── openssl@1.1
│ └── ca-certificates
└── pkg-config

cargo-make
└── rust
├── openssl@1.1
│ └── ca-certificates
└── pkg-config

cargo-nextest
└── rust
├── openssl@1.1
│ └── ca-certificates
└── pkg-config

cargo-outdated
├── libgit2
│ └── libssh2
│ └── openssl@1.1
│ └── ca-certificates
├── openssl@1.1
│ └── ca-certificates
└── rust
├── openssl@1.1
│ └── ca-certificates
└── pkg-config

cargo-release
└── rust
├── openssl@1.1
│ └── ca-certificates
└── pkg-config

cargo-zigbuild
├── rust
│ ├── openssl@1.1
│ │ └── ca-certificates
│ └── pkg-config
└── zig
├── z3
└── zstd
├── lz4
└── xz

maturin
└── rust
├── openssl@1.1
│ └── ca-certificates
└── pkg-config

@ZhongRuoyu ZhongRuoyu added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Mar 9, 2023
@Porkepix
Copy link
Contributor

Porkepix commented Mar 9, 2023

This other formula is also compatible with OpenSSL 3.
Also, maybe rust could be switched as build dependency only there, and is Openssl still required on every OS for that dependents?

@ZhongRuoyu

This comment was marked as outdated.

@Porkepix
Copy link
Contributor

Porkepix commented Mar 9, 2023

is Openssl still required on every OS for that dependents?

Supposedly yes (and its dependency libgit2 needs it too). But it seems that it's already using a vendored libgit2. Mmm.

Both libgit2 and openssl can be used vendored from the repository I think. But homebrew's maintainer's policy is to use the dependency from homebrew's formulas when they exist rather than vendored ones.

@ZhongRuoyu

This comment was marked as outdated.

@ZhongRuoyu
Copy link
Member Author

ZhongRuoyu commented Mar 9, 2023

As for cargo-edit (update: and cargo-outdated), before we migrate their dependency libgit2 to openssl@3, maybe we can temporarily get rid of the audit failure by adding them to versioned_dependencies_conflicts_allowlist.json. Since they are both CLI-only.

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 9, 2023
@ZhongRuoyu ZhongRuoyu added the openssl-3-migration Related to switching to an OpenSSL 3 dependency label Mar 9, 2023
@chenrui333 chenrui333 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 10, 2023
@ZhongRuoyu ZhongRuoyu mentioned this pull request Mar 10, 2023
rust: update resources

rust: migrate to `openssl@3`
@ZhongRuoyu
Copy link
Member Author

ZhongRuoyu commented Mar 11, 2023

Failures

ARM & Intel

All macOS versions

ARM

Ventura

  • brew test --retry --verbose boringtun: boringtun: test #125501 Timeout::Error: execution expired (log). Concluded for now since the test could actually pass given a second chance.

Intel

All macOS versions

Ventura

  • brew test --retry --verbose bingrep: bingrep: improve test #125477 (Timeout::Error: execution expired (log; download raw log to see error message). Presumably due to the huge output size (~6k lines). To follow up after merge.)

Monterey

Bonus

This was an ignored warning:

==> brew linkage --cached --test --strict cargo-release
==> FAILED
Full linkage --cached --test --strict cargo-release output
  Undeclared dependencies with linkage:
    openssl@1.1
Truncated linkage --cached --test --strict cargo-release output
  Warning: Undeclared dependencies with linkage:
    openssl@1.1

@chenrui333
Copy link
Member

lexicon should be good now, #118944

@p-linnane p-linnane removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 12, 2023
@ZhongRuoyu
Copy link
Member Author

Merging. Will follow up as per #125208 (comment).

@BrewTestBot
Copy link
Member

:shipit: @ZhongRuoyu has triggered a merge.

@ZhongRuoyu ZhongRuoyu deleted the bump-rust-1.68.0 branch March 13, 2023 10:23
@ZhongRuoyu ZhongRuoyu mentioned this pull request Mar 13, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing openssl-3-migration Related to switching to an OpenSSL 3 dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants