Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bingrep: improve test #125477

Merged
merged 1 commit into from
Mar 13, 2023
Merged

bingrep: improve test #125477

merged 1 commit into from
Mar 13, 2023

Conversation

ZhongRuoyu
Copy link
Member

@ZhongRuoyu ZhongRuoyu commented Mar 12, 2023

The test timed out in #125208, presumably due to the huge output size (~6k lines). Let's try with a simpler binary instead.

To make sure, I'll rebase this and mark it as ready after #125208 is merged.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added the rust Rust use is a significant feature of the PR or issue label Mar 12, 2023
@ZhongRuoyu ZhongRuoyu mentioned this pull request Mar 12, 2023
The test could time out due to the huge output size. Try with a simpler
binary instead.
@ZhongRuoyu ZhongRuoyu marked this pull request as ready for review March 13, 2023 10:26
@ZhongRuoyu ZhongRuoyu added ready to merge PR can be merged once CI is green and removed do not merge labels Mar 13, 2023
@carlocab carlocab added the CI-no-bottles Merge without publishing bottles label Mar 13, 2023
@ZhongRuoyu ZhongRuoyu merged commit f7a21e8 into Homebrew:master Mar 13, 2023
@ZhongRuoyu ZhongRuoyu deleted the bingrep-test branch March 13, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants