Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adb-enhanced 2.5.21 (new formula) #132792

Merged
merged 2 commits into from Jul 4, 2023
Merged

adb-enhanced 2.5.21 (new formula) #132792

merged 2 commits into from Jul 4, 2023

Conversation

ashishb
Copy link
Contributor

@ashishb ashishb commented Jun 4, 2023 •
edited

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autosquash Automatically squash pull request commits according to Homebrew style. python Python use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Jun 4, 2023
@ashishb ashishb closed this Jun 4, 2023
@ashishb ashishb reopened this Jun 4, 2023
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jun 4, 2023
chenrui333
chenrui333 reviewed Jun 4, 2023
View reviewed changes
Formula/adb-enhanced.rb Outdated Show resolved Hide resolved
chenrui333
chenrui333 reviewed Jun 4, 2023
View reviewed changes
Formula/adb-enhanced.rb Outdated Show resolved Hide resolved
@ashishb ashishb changed the title Add adb-enhanced Add adb-enhanced 2.5.21 Jun 4, 2023
@chenrui333 chenrui333 changed the title Add adb-enhanced 2.5.21 adb-enhanced 2.5.21 (new formula) Jun 4, 2023
chenrui333
chenrui333 reviewed Jun 4, 2023
View reviewed changes
Formula/adb-enhanced.rb Outdated Show resolved Hide resolved
chenrui333
chenrui333 previously approved these changes Jun 4, 2023
View reviewed changes
@ashishb
Copy link
Contributor Author

ashishb commented Jun 4, 2023

@chenrui333 the tests are failing after your changes 6e7cae1
Is it ok to revert them?

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jun 4, 2023
@chenrui333
Copy link
Member

@chenrui333 the tests are failing after your changes 6e7cae1 Is it ok to revert them?

that actually passed in my local 🤔

@ashishb
Copy link
Contributor Author

ashishb commented Jun 4, 2023 •
edited

@chenrui333 the tests are failing after your changes 6e7cae1 Is it ok to revert them?

that actually passed in my local 🤔

However, it fails on GitHub Actions - https://github.com/Homebrew/homebrew-core/actions/runs/5170703471/jobs/9313853629?pr=132792

Let me see how I can fix it while including your changes.

@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jun 4, 2023
@ashishb
Copy link
Contributor Author

ashishb commented Jun 4, 2023

The tests are passing again.
@chenrui333 I added the comments back as I think they are useful for future updates.

@ashishb
Copy link
Contributor Author

ashishb commented Jun 5, 2023

@chenrui333 what do I have to do to merge this in? Seems like your approval isn't sufficient.

chenrui333
chenrui333 reviewed Jun 5, 2023
View reviewed changes
Formula/adb-enhanced.rb Outdated Show resolved Hide resolved
chenrui333
chenrui333 reviewed Jun 5, 2023
View reviewed changes
Formula/adb-enhanced.rb Outdated Show resolved Hide resolved
chenrui333
chenrui333 reviewed Jun 5, 2023
View reviewed changes
Formula/adb-enhanced.rb Outdated Show resolved Hide resolved
@chenrui333 chenrui333 dismissed their stale review June 5, 2023 14:24

still in progress

@chenrui333
Copy link
Member

left couple of comments for your PR, also can you squash your commits into one commit and use commit message as adb-enhanced 2.5.21 (new formula)

@chenrui333 chenrui333 added the almost there PR is nearly ready to merge label Jun 5, 2023
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 5, 2023
@ashishb
Copy link
Contributor Author

ashishb commented Jun 5, 2023 •
edited

left couple of comments for your PR, also can you squash your commits into one commit and use commit message as adb-enhanced 2.5.21 (new formula)

Done.
I resolved all except one comment.

@ashishb
Copy link
Contributor Author

ashishb commented Jun 8, 2023

@chenrui333 any suggestions here?

@ashishb ashishb closed this Jun 19, 2023
@ashishb ashishb reopened this Jun 19, 2023
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request and removed automerge-skip `brew pr-automerge` will skip this pull request labels Jun 20, 2023
@ashishb
Copy link
Contributor Author

ashishb commented Jun 23, 2023

@SMillerDev this is ready again for the review

SMillerDev
SMillerDev reviewed Jun 26, 2023
View reviewed changes
Formula/adb-enhanced.rb Outdated Show resolved Hide resolved
SMillerDev
SMillerDev reviewed Jun 28, 2023
View reviewed changes
Formula/adb-enhanced.rb Outdated Show resolved Hide resolved
@ashishb
adb-enhanced 2.5.21 (new formula)
35b1af9 
Add formula for adb-enhanced 2.5.21.
ADB-Enhanced is a Swiss-army knife for Android testing and development. A command-line interface to trigger various scenarios like screen rotation, battery saver mode, data saver mode, doze mode, permission grant/revocation. Its a wrapper around adb and not a replacement.
Ref: https://github.com/ashishb/adb-enhanced
@ashishb
Copy link
Contributor Author

ashishb commented Jun 30, 2023

@SMillerDev Thanks for approving. Can you merge it as well? It seems I don't have the right to merge this pull request.

@ashishb
Copy link
Contributor Author

ashishb commented Jul 3, 2023

@chenrui333 Assume you have write access, can you merge it in?

@chenrui333 chenrui333 removed the almost there PR is nearly ready to merge label Jul 4, 2023
@chenrui333
Copy link
Member

@chenrui333 Assume you have write access, can you merge it in?

Sorry about the delay, good for the merge now!

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

:shipit: @chenrui333 has requested bottles to be published to this PR.

@chenrui333
Copy link
Member

@ashishb thanks a lot for your efforts and patience on this PR. 🎉

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 4, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 4, 2023
Merged via the queue into Homebrew:master with commit 2874bec Jul 4, 2023
12 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ashishb @chenrui333 @SMillerDev @BrewTestBot