Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ode 0.15.2 #13761

Closed
wants to merge 3 commits into from
Closed

ode 0.15.2 #13761

wants to merge 3 commits into from

Conversation

jslee02
Copy link
Contributor

@jslee02 jslee02 commented May 20, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This PR changes to:

@jslee02 jslee02 changed the title Bump ode version to 0.15.2 ode 0.15.2 May 20, 2017
@ilovezfs
Copy link
Contributor

ilovezfs commented May 20, 2017

@jslee02 why did the with-libccd option not previously cause a depends_on "homebrew/science/libccd"?

@jslee02
Copy link
Contributor Author

jslee02 commented May 20, 2017

@ilovezfs It seems ode use the internal libccd when libccd is not installed. So depends_on "homebrew/science/libccd" seems unnecessary here. Let me remove the line and close #13762.

@fxcoudert
Copy link
Member

Build error on Sierra:

./threading_impl_posix.h:166:37: error: use of undeclared identifier 'pthread_condattr_setclock'; did you mean 'pthread_condattr_setpshared'?

Test error on El Capitan:

Undefined symbols for architecture x86_64:
  "_clock_gettime", referenced from:
      dxCondvarWakeup::BlockAsAWaiter(dxThreadedWaitTime const*) in libode.a(threading_impl.o)
ld: symbol(s) not found for architecture x86_64

@ilovezfs
Copy link
Contributor

Please report these errors upstream and consider submitting a new PR when it builds on El Capitan and Sierra.

@ilovezfs ilovezfs closed this May 25, 2017
@jslee02 jslee02 deleted the ode/bump_to_0.15.2 branch February 11, 2018 19:19
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants