pdfpc 4.6.0 #155471
Closed
pdfpc 4.6.0 #155471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <rui@chenrui.dev> Co-authored-by: Sean Molenaar <sean@seanmolenaar.eu>
Closed
chenrui333
added
the
CI-no-fail-fast
|
chenrui333
commented
Nov 25, 2023
| depends_on "qrencode" | ||
|
|
||
| on_linux do | ||
| depends_on "webkitgtk" |
There was a problem hiding this comment.
-- Checking for module 'webkit2gtk-4.0'
-- No package 'webkit2gtk-4.0' found
CMake Error at /home/linuxbrew/.linuxbrew/Cellar/cmake/3.27.8/share/cmake/Modules/FindPkgConfig.cmake:607 (message):
A required package was not found
Call Stack (most recent call first):
/home/linuxbrew/.linuxbrew/Cellar/cmake/3.27.8/share/cmake/Modules/FindPkgConfig.cmake:[82](https://github.com/Homebrew/homebrew-core/actions/runs/6986179004/job/19011401575?pr=155471#step:4:83)9 (_pkg_check_modules_internal)
src/CMakeLists.txt:33 (pkg_check_modules)
There was a problem hiding this comment.
Interestingly, we install include/webkitgtk-4.1/ / libexec/webkit2gtk-4.1/, not version 4.0 ..
pdfpc is expliciltely looking for 4.0 here: https://github.com/pdfpc/pdfpc/blob/14344bc203cfff71a1b72deb161e003c9b480bb2/src/CMakeLists.txt#L35-L38
There was a problem hiding this comment.
Good find, let me raise it up.
- there is an open issue on this, Support for webkit2gtk-4.1 pdfpc/pdfpc#671
chenrui333
added
build failure
|
some related upstream dependency support issues: |
|
Gonna close the PR for now (due to the upstream issues) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?continuing #118911