Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support libsoup3 #664

Open
chenrui333 opened this issue Dec 25, 2022 · 9 comments · Fixed by #666
Open

Support libsoup3 #664

chenrui333 opened this issue Dec 25, 2022 · 9 comments · Fixed by #666

Comments

@chenrui333
Copy link

No description provided.

@fnevgeny
Copy link
Member

Why should we? I see no missing functionality in v2, as far as pdfpc is concerned. Furthermore, libsoup2 is the standard part of the latest LTS Ubuntu; libsoup3 isn't (it's in the Universe).

@chenrui333
Copy link
Author

Maybe just relax the requirement for libsoup2?

As for the ubuntu, I think the reason might be the other way around, because nobody supports libsoup3, it is hard to put it as default.

@fnevgeny
Copy link
Member

Maybe just relax the requirement for libsoup2?

Where do you see this requirement? It's said "libsoup", not mentioning any specific version.

As for the ubuntu, I think the reason might be the other way around, because nobody supports libsoup3, it is hard to put it as default.

Frankly, I doubt that pdfpc through its (optional) dependence on libsoup would make any impact on Ubuntu's (or actually Debian's) decision which version to install by default...

@chenrui333
Copy link
Author

Maybe just relax the requirement for libsoup2?

Where do you see this requirement? It's said "libsoup", not mentioning any specific version.

I can see in here

pdfpc/src/CMakeLists.txt

Lines 38 to 49 in b62ef90

if (REST)
pkg_check_modules(SOUP REQUIRED libsoup-2.4)
pkg_check_modules(QRENCODE REQUIRED libqrencode)
set(REST_PACKAGES
libsoup-2.4
)
if (${CMAKE_HOST_WIN32})
# Needed for Posix.gethostname()
set(WSOCK32_LIB wsock32)
endif ()
endif ()

As for the ubuntu, I think the reason might be the other way around, because nobody supports libsoup3, it is hard to put it as default.

Frankly, I doubt that pdfpc through its (optional) dependence on libsoup would make any impact on Ubuntu's (or actually Debian's) decision which version to install by default...

that is true, but just saying the ecosystem change is hard :)

@fnevgeny
Copy link
Member

I can see in here

Oops, indeed, sorry :). Well, you can change it to 3.0 and see how it goes.

@chenrui333
Copy link
Author

I can see in here

Oops, indeed, sorry :). Well, you can change it to 3.0 and see how it goes.

Yeah, I can give that a try. i will report it back. 👍

@chenrui333
Copy link
Author

chenrui333 commented Dec 29, 2022

Yeah, loosing the libsoup requirement works for me.

@fnevgeny
Copy link
Member

Good, please give #666 (what a number! :)) a try.

@AndreasBilke
Copy link
Member

In #667 we saw that we cannot simply support both libsoup versions since they are incompatible. I also revert the already made changes to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants