Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresql@* libpq: fix compatibility with openssl 3.2 #155699

Merged
merged 14 commits into from
Nov 28, 2023

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Nov 28, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This PR ports an upstream patch (not merged yet) to postgresql@11-16, libpq formulae.

Closes #155651

UPD: The patch has been merged to Postgres: postgres/postgres@c82207a

@bayandin bayandin requested a review from Bo98 November 28, 2023 00:26
@github-actions github-actions bot added the icu4c ICU use is a significant feature of the PR or issue label Nov 28, 2023
@Bo98
Copy link
Member

Bo98 commented Nov 28, 2023

I think the configure modifications are triggering the doc builds, which is not working it seems. The docs are prebuilt in the archive but it's likely rebuilding when a change to configure is detected.

You can simplify the patches to just the two [bf]e-secure-openssl.c files. Everything else is cleanup that is largely irrelevant for us.

@tristan957
Copy link

Also looks like my patch will grow to also include some test updates, but I doubt that is relevant for Homebrew. Stay tuned on the mailing list discussion.

@bayandin bayandin force-pushed the postgreses-patch-for-openssl@3.2 branch from 4f2bb82 to 1aaca15 Compare November 28, 2023 09:58
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 28, 2023
@bayandin bayandin force-pushed the postgreses-patch-for-openssl@3.2 branch from 1aaca15 to 2a60750 Compare November 28, 2023 09:59
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 28, 2023
@bayandin
Copy link
Member Author

You can simplify the patches to just the two [bf]e-secure-openssl.c files. Everything else is cleanup that is largely irrelevant for us.

Makes sense, applied!

@bayandin
Copy link
Member Author

Tested locally (macOS: 14.1.1-arm64) that it works:

# for v in 16 15 14 13 12 11; do HOMEBREW_NO_INSTALL_FROM_API=1 brew reinstall -s -v postgresql@$v; done
# HOMEBREW_NO_INSTALL_FROM_API=1 brew reinstall -s -v libpq

CONNSTR="postgresql://..."
for v in 16 15 14 13 12 11; do echo -n "postgresql@$v: "; /opt/homebrew/opt/postgresql@${v}/bin/psql "$CONNSTR?sslmode=require" -qAtX -c "select 'ok'"; done
echo -n "libpq: "; /opt/homebrew/opt/libpq/bin/psql "$CONNSTR?sslmode=require" -qAtX -c "select 'ok'"
postgresql@16: ok
postgresql@15: ok
postgresql@14: ok
postgresql@13: ok
postgresql@12: ok
postgresql@11: ok
libpq: ok

@Bo98 Bo98 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Nov 28, 2023
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 28, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 28, 2023
Merged via the queue into master with commit 8960b2f Nov 28, 2023
12 of 13 checks passed
@BrewTestBot BrewTestBot deleted the postgreses-patch-for-openssl@3.2 branch November 28, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. icu4c ICU use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openssl@3.2.0 update makes psql crash when connecting with TLS
5 participants