Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff-so-fancy: Add installation from HEAD #15729

Merged
merged 4 commits into from
Jul 20, 2017
Merged

diff-so-fancy: Add installation from HEAD #15729

merged 4 commits into from
Jul 20, 2017

Conversation

jeffbyrnes
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Ran into this when trying to fix so-fancy/diff-so-fancy#243

@mbanyar033
Copy link

😁

@jeffbyrnes
Copy link
Contributor Author

Slight tweak, as it turns out, the master branch is not their bleeding edge.

@fxcoudert fxcoudert merged commit 1bf6366 into Homebrew:master Jul 20, 2017
@fxcoudert
Copy link
Member

Thanks @jeffbyrnes for your contribution to Homebrew!

@jeffbyrnes jeffbyrnes deleted the add-head-for-diff-so-fancy branch July 20, 2017 13:15
@jeffbyrnes
Copy link
Contributor Author

You’re welcome! Glad to do it after so many years of being a happy user.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of uninitialized value $value in substitution (s///) at /usr/local/bin/diff-so-fancy line 370
3 participants