kyma-cli: update sha256, add livecheck #157653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
go
samford
added
livecheck
samford
force-pushed
the
kyma-cli-update-sha256-add-livecheck
branch
from
2b3b138
to
2fee85c
Compare
github-actions
bot
added
the
go
chenrui333
added
upstream issue
|
|
Upstream confirmed the re-tag in kyma-project/cli#1888 (comment) How do we deal with the |
chenrui333
added
the
CI-no-fail-fast
chenrui333
approved these changes
Dec 22, 2023
p-linnane
approved these changes
Dec 22, 2023
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?kyma-cliwas recently updated to 2.20.1 (#157340) but yesterday livecheck was reporting 2.20.0 as the newest version (from the Git tags), so the 2.20.1 tag was seemingly removed and re-created between the formula update and now. The GitHub release for 2.20.1 was only created a few hours ago (i.e., a few days after the formula was updated).I've asked upstream to confirm the checksum change (kyma-project/cli#1888), so I've set this as a draft until I hear back. The only commit between now and then was to update the kyma-incubator/reconciler version in
go.mod(kyma-project/cli@73bea7c) but we will seemingly need new bottles to account for that. I'm not sure how big of a change that is but this may need arevisionbump.Past that, this PR adds a
livecheckblock that uses theGithubLateststrategy, as it appears that upstream uses GitHub releases to indicate when a version is actually released. This will help to ensure that we don't run into this issue again, if upstream re-tags a version before the release is created.