Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-sitter: remove wasm libs #159082

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Building wasm libs requires a specific version of emscripten. No other major packager ships wasm libraries, so this PR removes them so tree-sitter can build successfully again.

Closes #158998

@github-actions github-actions bot added nodejs Node or npm use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue labels Jan 5, 2024
@p-linnane p-linnane mentioned this pull request Jan 5, 2024
6 tasks
Copy link
Contributor

github-actions bot commented Jan 5, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 5, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 5, 2024
Merged via the queue into Homebrew:master with commit a3dadf6 Jan 5, 2024
12 checks passed
@p-linnane p-linnane deleted the tree-sitter-remove-wasm branch January 5, 2024 23:22
@MikeMcQuaid
Copy link
Member

Makes sense to me, thanks @p-linnane!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. nodejs Node or npm use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants