fix(wasm): remove C++ mangled symbols #2971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No more upstream scanners use C++ so we're going to encourage to prefer using C instead. It is just much easier to work with overall
amaanq
changed the title
amaanq
changed the title
|
Well that was a painful 3 hours of finding that ruby bug, now we can get this in |
|
Just as a heads up, since you linked my issue, we dropped wasm support in Homebrew in Homebrew/homebrew-core#159082. I'll leave a comment in the original issue as well. |
|
ah ok, thanks for the heads up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably fixes #2803