Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace shell_profile calls in formulae #16143

Closed
wants to merge 6 commits into from

Conversation

bfontaine
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

I got some exceptions while loading formulae in no-compat mode, since shell_profile is now defined in compat/utils.rb.

@MikeMcQuaid
Copy link
Member

We're actually doing this in reverse in Homebrew/brew#2899 because the previous naming is nicer. Sorry @bfontaine!

@bfontaine bfontaine deleted the shell_profile branch July 28, 2017 09:28
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants